From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>
Subject: Re: Regulator probe
Date: Thu, 01 Sep 2016 19:15:16 +0300 [thread overview]
Message-ID: <1472746516.4887.489.camel@linux.intel.com> (raw)
In-Reply-To: <20160901153836.GI5967@sirena.org.uk>
On Thu, 2016-09-01 at 16:38 +0100, Mark Brown wrote:
> On Thu, Sep 01, 2016 at 05:53:43PM +0300, Andy Shevchenko wrote:
>
> >
> > [ 20.843973] calling sdhci_drv_init+0x0/0x20 @ 1
> > [ 20.843976] sdhci: Secure Digital Host Controller Interface
> > driver
> > [ 20.843978] sdhci: Copyright(c) Pierre Ossman
> > [ 20.843989] initcall sdhci_drv_init+0x0/0x20 returned 0 after 5
> > usecs
> > [ 20.843999] calling sdhci_driver_init+0x0/0x1b @ 1
> >
> > [ 20.881460] sdhci-pci 0000:00:01.3: SDHCI controller found
> > [8086:1190] (rev 1)
> > [ 20.881471] sdhci-pci 0000:00:01.3: found 1 slot(s)
> > [ 20.888242] sdhci-pci 0000:00:01.3: No vmmc regulator found
>
> >
> > ^^^^^ PROBLEM!
> >
> > Regulator is present, though it's in a waiting list.
>
> The device isn't registered and it's saying it isn't registered, this
> is
> normal. Since this is an ACPI system
Nope, it's SFI. Which basically means we have everything in board files.
> we are expecting the firmware or
> whatever else registers devices and their supplies to do that, if the
> supplies aren't being mapped at device registration time then you're
> telling the core not to expect any. If you had mapped the supply and
> it
> wasn't available the consumer would get an -EPROBE_DEFER.
Basically you mean we have not call regulator_has_full_constraints()?
In that case we have to provide stubs for all expected regulators, in
case of SDHCI one real and one dummy, who knows how many them in the
drivers, but for each we have to provide that. Am I right?
>
> As I keep saying with all these problems if you want to reimplement DT
> instead of using it you need to reimplement *all* of DT, it's there
> for
> a reason. It would be a lot quicker and simpler to just use DT for
> these systems.
Here we have platform code. It might be possible to switch to DT for it,
with no firmware support, but I can consider it as a far away from now.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-09-01 16:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 14:53 Regulator probe Andy Shevchenko
2016-09-01 15:38 ` Mark Brown
2016-09-01 16:15 ` Andy Shevchenko [this message]
2016-09-01 17:02 ` Mark Brown
2016-09-05 16:01 ` Andy Shevchenko
2016-09-06 10:24 ` Mark Brown
2016-09-07 14:24 ` Andy Shevchenko
2016-09-09 12:17 ` Mark Brown
2016-09-09 12:55 ` Andy Shevchenko
2016-09-09 15:29 ` Mark Brown
2016-09-09 16:10 ` Andy Shevchenko
2016-09-09 16:38 ` Mark Brown
2016-09-09 17:04 ` Andy Shevchenko
2016-09-09 17:18 ` Mark Brown
2016-09-10 11:03 ` Andy Shevchenko
2016-09-12 15:27 ` Mark Brown
2016-09-12 16:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472746516.4887.489.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).