From: J Freyensee <james_p_freyensee@linux.intel.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] nvme: Enable autonomous power state transitions
Date: Fri, 02 Sep 2016 11:11:19 -0700 [thread overview]
Message-ID: <1472839879.2754.77.camel@linux.intel.com> (raw)
In-Reply-To: <CALCETrUFRhNTamd-u_K+KTowN9S8WJKgreUQ4mfxmfx5v8zSPQ@mail.gmail.com>
> > >
> > >
> > > >
> > > > + /*
> > > > + * By default, allow up to 25ms of APST-induced
> > > > latency. This will
> > > > + * have no effect on non-APST supporting controllers
> > > > (i.e.
> > > > any
> > > > + * controller with APSTA == 0).
> > > > + */
> > > > + ctrl->apst_max_latency_ns = 25000000;
> > >
> > > Is it possible to make that a #define please?
> >
> > I'll make it a module parameter as Keith suggested.
>
> One question, though: should we call this and the sysfs parameter
> apst_max_latency or should it be more generically
> power_save_max_latency? The idea is that we might want to support
> non-automonous transitions some day or even runtime D3. Or maybe
> those should be separately configured if used.
I read the spec and reviewed your latest patchset. Personally for me I
like having the field names from the NVMe spec in the names of the
Linux implementation because it makes it easier to find and relate the
two. So apst_max_latency makes more sense to me, as this is a
'apst'(e/a) NVMe feature.
>
> --Andy
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2016-09-02 18:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 9:25 [PATCH 0/3] nvme power saving Andy Lutomirski
2016-08-29 9:25 ` [PATCH 1/3] nvme/scsi: Remove power management support Andy Lutomirski
2016-08-29 9:25 ` [PATCH 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski
2016-08-29 16:27 ` Keith Busch
2016-08-29 23:20 ` Andy Lutomirski
2016-08-30 6:36 ` Christoph Hellwig
2016-08-30 16:00 ` Andy Lutomirski
2016-08-29 9:25 ` [PATCH 3/3] nvme: Enable autonomous power state transitions Andy Lutomirski
2016-08-29 15:07 ` J Freyensee
2016-08-29 23:16 ` Andy Lutomirski
2016-08-30 20:21 ` Andy Lutomirski
2016-09-02 18:11 ` J Freyensee [this message]
2016-09-02 18:50 ` Andy Lutomirski
2016-08-29 16:45 ` Keith Busch
2016-08-29 23:16 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472839879.2754.77.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=luto@amacapital.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox