linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tomasz Figa <tomasz.figa@gmail.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	Kukjin Kim <kgene@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	javier@osg.samsung.com, Linus Walleij <linus.walleij@linaro.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Subject: [PATCH v3 02/17] pinctrl: dt-bindings: samsung: Update documentation with new macros
Date: Sun,  4 Sep 2016 13:04:05 +0200	[thread overview]
Message-ID: <1472987060-28293-3-git-send-email-krzk@kernel.org> (raw)
In-Reply-To: <1472987060-28293-1-git-send-email-krzk@kernel.org>

From: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Update examples in Samsung pinctrl dt-bindings with new macros coming
from header file.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

Changes since v1:
1. Add Javier's reviewed-by.
2. Include necessary header in example (pointed by Javier).
---
 .../bindings/pinctrl/samsung-pinctrl.txt           | 44 +++++++++++-----------
 1 file changed, 23 insertions(+), 21 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
index 6db16b90873a..d49e22d2a8b5 100644
--- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
@@ -229,6 +229,8 @@ Example: A pin-controller node with pin banks:
 
 Example 1: A pin-controller node with pin groups.
 
+	#include <dt-bindings/pinctrl/samsung.h>
+
 	pinctrl_0: pinctrl@11400000 {
 		compatible = "samsung,exynos4210-pinctrl";
 		reg = <0x11400000 0x1000>;
@@ -238,53 +240,53 @@ Example 1: A pin-controller node with pin groups.
 
 		uart0_data: uart0-data {
 			samsung,pins = "gpa0-0", "gpa0-1";
-			samsung,pin-function = <2>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
+			samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+			samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+			samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 		};
 
 		uart0_fctl: uart0-fctl {
 			samsung,pins = "gpa0-2", "gpa0-3";
-			samsung,pin-function = <2>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
+			samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+			samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+			samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 		};
 
 		uart1_data: uart1-data {
 			samsung,pins = "gpa0-4", "gpa0-5";
-			samsung,pin-function = <2>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
+			samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+			samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+			samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 		};
 
 		uart1_fctl: uart1-fctl {
 			samsung,pins = "gpa0-6", "gpa0-7";
-			samsung,pin-function = <2>;
-			samsung,pin-pud = <0>;
-			samsung,pin-drv = <0>;
+			samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+			samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+			samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 		};
 
 		i2c2_bus: i2c2-bus {
 			samsung,pins = "gpa0-6", "gpa0-7";
-			samsung,pin-function = <3>;
-			samsung,pin-pud = <3>;
-			samsung,pin-drv = <0>;
+			samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+			samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+			samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 		};
 
 		sd4_bus8: sd4-bus-width8 {
 			part-1 {
 				samsung,pins = "gpk0-3", "gpk0-4",
 						"gpk0-5", "gpk0-6";
-				samsung,pin-function = <3>;
-				samsung,pin-pud = <3>;
-				samsung,pin-drv = <3>;
+				samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+				samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+				samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
 			};
 			part-2 {
 				samsung,pins = "gpk1-3", "gpk1-4",
 						"gpk1-5", "gpk1-6";
-				samsung,pin-function = <4>;
-				samsung,pin-pud = <4>;
-				samsung,pin-drv = <3>;
+				samsung,pin-function = <EXYNOS_PIN_FUNC_4>;
+				samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+				samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
 			};
 		};
 	};
-- 
2.7.4

  parent reply	other threads:[~2016-09-04 11:05 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-04 11:04 [PATCH v3 00/17] pinctrl: exynos/samsung: Add header with values used for configuration Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 01/17] pinctrl: dt-bindings: samsung: " Krzysztof Kozlowski
2016-09-07 21:18   ` Linus Walleij
     [not found]     ` <CGME20160916075624eucas1p23a12de912f92f0c557f17fbd394b186e@eucas1p2.samsung.com>
2016-09-16  7:56       ` Krzysztof Kozlowski
2016-09-04 11:04 ` Krzysztof Kozlowski [this message]
2016-09-07 21:19   ` [PATCH v3 02/17] pinctrl: dt-bindings: samsung: Update documentation with new macros Linus Walleij
2016-09-12 16:10   ` Rob Herring
2016-09-04 11:04 ` [PATCH v3 03/17] ARM: dts: exynos: Use common macros for pinctrl configuration Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 04/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos3250 Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 05/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4210 Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 06/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4x12 Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 07/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos4415 Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 08/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5250 Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 09/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5260 Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 10/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos5410 Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 11/17] ARM: dts: exynos: Use macros for pinctrl configuration on exynos542x/exynos5800 Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 12/17] ARM: dts: exynos: Fix mismatched value for SD4 pull up/down configuration on exynos4210 Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 13/17] ARM: dts: exynos: Fix mismatched values of SD drive strengh configuration on exynos4415 Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 14/17] ARM: dts: s3c64xx: Use common macros for pinctrl configuration Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 15/17] ARM: dts: s5pv210: Use " Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 16/17] ARM: dts: s3c2416: " Krzysztof Kozlowski
2016-09-04 11:04 ` [PATCH v3 17/17] ARM: dts: s3c64xx: " Krzysztof Kozlowski
2016-10-09  7:04 ` [PATCH v3 00/17] pinctrl: exynos/samsung: Add header with values used for configuration Tomasz Figa
2016-10-09 16:39   ` Krzysztof Kozlowski
2016-10-09 17:49     ` Tomasz Figa
2016-10-09 17:52       ` Krzysztof Kozlowski
2016-10-21  9:02 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472987060-28293-3-git-send-email-krzk@kernel.org \
    --to=krzk@kernel.org \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=javier@osg.samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).