From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
Dan Carpenter <error27@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Add a --strict test for macro argument reuse and precedence
Date: Sun, 04 Sep 2016 07:42:43 -0700 [thread overview]
Message-ID: <1473000163.5018.21.camel@perches.com> (raw)
In-Reply-To: <5ef3db05b4021f41d313e265f4c9ebd259c808ee.1472940911.git.joe@perches.com>
On Sat, 2016-09-03 at 15:20 -0700, Joe Perches wrote:
> Add a test for reuse of macro arguments to highlight any possible
> side-effects from this reuse.
>
> Avoid this check on token name pasting and when the
> argument is used in a typeof or a __builtin.
>
> Add a test for macro arguents that have leading or trailing operators
> where the argument isn't parenthesized to avoid possible precedence
> issues.
>
> These tests are noisy so make them --strict.
This should have been RFC. Please do not apply this.
These tests are not just noisy, some false positives it
reports are just silly.
next prev parent reply other threads:[~2016-09-04 14:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 18:35 Possible code defects: macros and precedence Joe Perches
2016-09-03 20:18 ` Dan Carpenter
2016-09-03 22:20 ` [PATCH] checkpatch: Add a --strict test for macro argument reuse " Joe Perches
2016-09-04 14:42 ` Joe Perches [this message]
2016-09-04 10:10 ` Possible code defects: macros " Julia Lawall
2016-09-04 15:06 ` Joe Perches
[not found] ` <alpine.DEB.2.10.1609172221110.3124@hadrien>
2016-09-17 21:27 ` Joe Perches
2016-09-18 5:09 ` Julia Lawall
2016-09-18 9:31 ` Joe Perches
2016-09-20 13:14 ` Julia Lawall
2016-09-20 17:07 ` Joe Perches
2016-09-20 18:03 ` Joe Perches
2016-09-20 23:47 ` Joe Perches
2016-09-21 5:04 ` Julia Lawall
2016-09-17 21:57 ` Joe Perches
2016-09-18 4:57 ` Julia Lawall
2016-09-18 9:27 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473000163.5018.21.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=error27@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox