From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754651AbcIDVW0 (ORCPT ); Sun, 4 Sep 2016 17:22:26 -0400 Received: from smtprelay0126.hostedemail.com ([216.40.44.126]:36533 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754040AbcIDVWY (ORCPT ); Sun, 4 Sep 2016 17:22:24 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:2892:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3872:3873:4250:4321:5007:7576:8603:10004:10400:10848:10967:11232:11658:11783:11914:12043:12555:12740:13069:13311:13357:13439:13894:14181:14659:14721:21080:21212:21433:30054:30070:30075:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: flame54_14a98025fed57 X-Filterd-Recvd-Size: 2027 Message-ID: <1473024140.5018.61.camel@perches.com> Subject: Re: [PATCH] qed: Remove OOM messages From: Joe Perches To: David Miller Cc: Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com, everest-linux-l2@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 04 Sep 2016 14:22:20 -0700 In-Reply-To: <20160904.132854.1438256363591084718.davem@davemloft.net> References: <1472838261.6758.74.camel@perches.com> <6d6f56d8324237957b19f069357e2aa9e4bcd959.1472836194.git.joe@perches.com> <20160904.132854.1438256363591084718.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-09-04 at 13:28 -0700, David Miller wrote: > From: Joe Perches > Date: Fri,  2 Sep 2016 10:48:47 -0700 > > > These messages are unnecessary as OOM allocation failures already do > > a dump_stack() giving more or less the same information. > >  > > $ size drivers/net/ethernet/qlogic/qed/built-in.o* (defconfig x86-64) > >    text          data     bss     dec     hex filename > >  126849         27968   32800  187617   2dce1 drivers/net/ethernet/qlogic/qed/built-in.o.new > >  131506         27968   32800  192274   2ef12 drivers/net/ethernet/qlogic/qed/built-in.o.old > >  > > Miscellanea: > >  > > o Change allocs to the generally preferred forms where possible. > >  > > Signed-off-by: Joe Perches > > Joe can you respin this against net-next? > > It applies against 'net' but this isn't really a critical bug fix and > it'll also create conflicts against net-next. No worries, I'll spin it back after the qed -net changes are pushed back into net-next. Oh, they are now.  Give me a minute.