From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754853AbcIEFYx (ORCPT ); Mon, 5 Sep 2016 01:24:53 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:35837 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754721AbcIEFYu (ORCPT ); Mon, 5 Sep 2016 01:24:50 -0400 From: Taeung Song To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Masami Hiramatsu , Wang Nan , Taeung Song , Jiri Olsa , Ingo Molnar Subject: [PATCH v8 1/7] perf config: Introduce default_config_section and default_config_item for default config key-value pairs Date: Mon, 5 Sep 2016 14:24:34 +0900 Message-Id: <1473053080-23461-2-git-send-email-treeze.taeung@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1473053080-23461-1-git-send-email-treeze.taeung@gmail.com> References: <1473053080-23461-1-git-send-email-treeze.taeung@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When initializing default perf config values, we currently use values of actual type(int, bool, char *, etc.). For example, If there isn't a user config value for 'annotate.use_offset' config variable at ~/.perfconfig, default value for it is 'true' bool type value in perf like below. At ui/browsers/annoate.c static struct annotate_browser_opt { bool hide_src_code, use_offset, jump_arrows, show_linenr, show_nr_jumps, show_total_period; } annotate_browser__opts = { .use_offset = true, .jump_arrows = true, }; But I suggest using 'struct default_config_section' and 'struct default_config_item' that can contain default config key-value pairs in order to initialize default config values with them, in near future. If we do, we could manage default perf config values at one spot (i.e. util/config.c) with default config arrays and it could be easy and simple to modify existing default config values or add default values for new config item. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Wang Nan Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Masami Hiramatsu Signed-off-by: Taeung Song --- tools/perf/util/config.h | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h index 6f813d4..1fd8e4c 100644 --- a/tools/perf/util/config.h +++ b/tools/perf/util/config.h @@ -63,4 +63,33 @@ void perf_config__refresh(void); perf_config_sections__for_each_entry(&set->sections, section) \ perf_config_items__for_each_entry(§ion->items, item) +enum perf_config_type { + CONFIG_TYPE_BOOL, + CONFIG_TYPE_INT, + CONFIG_TYPE_LONG, + CONFIG_TYPE_U64, + CONFIG_TYPE_FLOAT, + CONFIG_TYPE_DOUBLE, + CONFIG_TYPE_STRING +}; + +struct default_config_item { + const char *name; + union { + bool b; + int i; + u32 l; + u64 ll; + float f; + double d; + const char *s; + } value; + enum perf_config_type type; +}; + +struct default_config_section { + const char *name; + const struct default_config_item *items; +}; + #endif /* __PERF_CONFIG_H */ -- 2.7.4