linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Giovanni Gherdovich <ggherdovich@suse.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	Mike Galbraith <mgalbraith@suse.de>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Rik van Riel <riel@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Wanpeng Li <wanpeng.li@hotmail.com>,
	Ingo Molnar <mingo@kernel.org>,
	Stanislaw Gruszka <sgruszka@redhat.com>
Subject: [PATCH v2 1/2] sched/cputime: Use only pi_lock to protect sum_exec_runtime read
Date: Mon,  5 Sep 2016 11:13:01 +0200	[thread overview]
Message-ID: <1473066782-19372-2-git-send-email-sgruszka@redhat.com> (raw)
In-Reply-To: <1473066782-19372-1-git-send-email-sgruszka@redhat.com>

Currently we protect 64bit sum_exec_runtime read on 32bit cpus using
task_rq_lock() which internally takes t->pi_lock and rq->lock. Taking
rq->lock is not needed in this case.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 kernel/sched/cputime.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
index b93c72d..5535774 100644
--- a/kernel/sched/cputime.c
+++ b/kernel/sched/cputime.c
@@ -315,12 +315,11 @@ static inline u64 read_sum_exec_runtime(struct task_struct *t)
 static u64 read_sum_exec_runtime(struct task_struct *t)
 {
 	u64 ns;
-	struct rq_flags rf;
-	struct rq *rq;
+	unsigned long flags;
 
-	rq = task_rq_lock(t, &rf);
+	raw_spin_lock_irqsave(&t->pi_lock, flags);
 	ns = t->se.sum_exec_runtime;
-	task_rq_unlock(rq, t, &rf);
+	raw_spin_unlock_irqrestore(&t->pi_lock, flags);
 
 	return ns;
 }
-- 
1.8.3.1

  reply	other threads:[~2016-09-05  9:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05  9:13 [PATCH v2 0/2] sched/cputime: sum_exec_runtime fixes for 32-bit cpus Stanislaw Gruszka
2016-09-05  9:13 ` Stanislaw Gruszka [this message]
2016-09-05 14:16   ` [PATCH v2 1/2] sched/cputime: Use only pi_lock to protect sum_exec_runtime read Stanislaw Gruszka
2016-09-05 19:16     ` Peter Zijlstra
2016-09-05  9:13 ` [PATCH v2 2/2] sched/cputime: Protect other sum_exec_runtime reads on 32 bit cpus Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473066782-19372-2-git-send-email-sgruszka@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=ggherdovich@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgalbraith@suse.de \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).