From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934010AbcIFJKD (ORCPT ); Tue, 6 Sep 2016 05:10:03 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35501 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933326AbcIFJJ7 (ORCPT ); Tue, 6 Sep 2016 05:09:59 -0400 From: Minfei Huang To: agk@redhat.com, snitzer@redhat.com, shli@kernel.org Cc: dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Minfei Huang Subject: [PATCH] dm: Return correct value in retry loop Date: Tue, 6 Sep 2016 16:00:29 +0800 Message-Id: <1473148829-3317-1-git-send-email-mnghuan@gmail.com> X-Mailer: git-send-email 2.7.4 (Apple Git-66) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dm_resume will return sliently in retry loop's failure. Assign a correct return value in the failed loop. Remove a useless assignment as well. Signed-off-by: Minfei Huang --- drivers/md/dm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm.c b/drivers/md/dm.c index fa9b1cb..c935cc8 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -2249,10 +2249,11 @@ static int __dm_resume(struct mapped_device *md, struct dm_table *map) int dm_resume(struct mapped_device *md) { - int r = -EINVAL; + int r; struct dm_table *map = NULL; retry: + r = -EINVAL; mutex_lock_nested(&md->suspend_lock, SINGLE_DEPTH_NESTING); if (!dm_suspended_md(md)) @@ -2277,10 +2278,8 @@ retry: clear_bit(DMF_SUSPENDED, &md->flags); - r = 0; out: mutex_unlock(&md->suspend_lock); - return r; } -- 2.7.4 (Apple Git-66)