From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934358AbcIFJ3D (ORCPT ); Tue, 6 Sep 2016 05:29:03 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:46883 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934321AbcIFJ27 (ORCPT ); Tue, 6 Sep 2016 05:28:59 -0400 Message-ID: <1473154130.2805.92.camel@pengutronix.de> Subject: Re: [PATCH] [media] coda: add missing header dependencies From: Philipp Zabel To: Arnd Bergmann Cc: Baoyou Xie , mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Date: Tue, 06 Sep 2016 11:28:50 +0200 In-Reply-To: <17845866.BEgCsGq73Z@wuerfel> References: <1473148256-25347-1-git-send-email-baoyou.xie@linaro.org> <17845866.BEgCsGq73Z@wuerfel> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, den 06.09.2016, 11:21 +0200 schrieb Arnd Bergmann: > On Tuesday, September 6, 2016 3:50:56 PM CEST Baoyou Xie wrote: > > #include > > #include > > +#include > > > > by convention, we tend to write this as > > #include "coda.h" > > otherwise the patch looks good to me, > > Acked-by: Arnd Bergmann Same here, make that + +#include "coda.h" and feel free to add Acked-by: Philipp Zabel thanks Philipp