From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>
Subject: Re: [v2 patch v3.18+ regression fix] sched: Further improve spurious CPU_IDLE active migrations
Date: Tue, 06 Sep 2016 15:44:03 +0200 [thread overview]
Message-ID: <1473169443.32128.23.camel@gmail.com> (raw)
In-Reply-To: <1473167264.32128.5.camel@gmail.com>
On Tue, 2016-09-06 at 15:07 +0200, Mike Galbraith wrote:
> On Tue, 2016-09-06 at 15:01 +0200, Vincent Guittot wrote:
> > Le Monday 05 Sep 2016 à 18:26:53 (+0200), Mike Galbraith a écrit :
> > > Coming back to this, how about this instead, only increase the
> > > group
> > > imbalance threshold when sd_llc_size == 2. Newer L3 equipped
> > > processors then aren't affected.
> > >
> >
> > Not sure that all systems with sd_llc_size == 2 wants this
> > behavior.
> >
> > Why not adding a sched_feature for changing the 2nd half of the
> > test
> > for some systems ?
>
> Because users won't know, and shouldn't need to know that they need to
> flip that switch.
The patchlet just puts these CPUs back in the same boat they were in
before Rik's patch landed. Also, if people are doing serious compute,
they're unlikely to leave any placement decisions up to the scheduler.
-Mike
prev parent reply other threads:[~2016-09-06 13:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 5:42 [patch v3.18+ regression fix] sched: Further improve spurious CPU_IDLE active migrations Mike Galbraith
2016-08-31 10:01 ` Peter Zijlstra
2016-08-31 10:18 ` Mike Galbraith
2016-08-31 10:36 ` Mike Galbraith
2016-08-31 15:52 ` Vincent Guittot
2016-09-01 4:11 ` Mike Galbraith
2016-09-01 6:37 ` Mike Galbraith
2016-09-01 8:09 ` Vincent Guittot
2016-09-05 16:26 ` [v2 patch " Mike Galbraith
2016-09-06 13:01 ` Vincent Guittot
2016-09-06 13:07 ` Mike Galbraith
2016-09-06 13:42 ` Vincent Guittot
2016-09-06 13:59 ` Mike Galbraith
2016-09-06 13:44 ` Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473169443.32128.23.camel@gmail.com \
--to=umgwanakikbuti@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).