From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756166AbcIGBUL (ORCPT ); Tue, 6 Sep 2016 21:20:11 -0400 Received: from smtprelay0059.hostedemail.com ([216.40.44.59]:42984 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755132AbcIGBUF (ORCPT ); Tue, 6 Sep 2016 21:20:05 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:69:355:379:541:599:800:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2740:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3872:4321:5007:6691:10004:10400:10848:11232:11658:11914:12043:12291:12296:12663:12683:12740:13069:13161:13229:13311:13357:13439:13894:14181:14659:14721:21080:30012:30029:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: trade34_120aa635cfd4a X-Filterd-Recvd-Size: 1875 Message-ID: <1473211122.29864.1.camel@perches.com> Subject: Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros From: Joe Perches To: Woojung.Huh@microchip.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org Cc: f.fainelli@gmail.com, UNGLinuxDriver@microchip.com, linux-kernel@vger.kernel.org Date: Tue, 06 Sep 2016 18:18:42 -0700 In-Reply-To: <9235D6609DB808459E95D78E17F2E43D40910FF9@CHN-SV-EXMX02.mchp-main.com> References: <9235D6609DB808459E95D78E17F2E43D40910FF9@CHN-SV-EXMX02.mchp-main.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-09-06 at 23:19 +0000, Woojung.Huh@microchip.com wrote: > > Joe Perches (2): > >   lan78xx: Remove locally defined trailing underscores from defines and uses > >   microchipphy.h and uses: Remove trailing underscores from defines and > > uses > > > >  drivers/net/phy/microchip.c | 4 +- > >  drivers/net/usb/lan78xx.c | 368 +++++++-------- > >  drivers/net/usb/lan78xx.h | 1068 +++++++++++++++++++++----------------- > > ---- > >  include/linux/microchipphy.h | 72 +-- > >  4 files changed, 756 insertions(+), 756 deletions(-) > > > Because there is no specific rule how to name defines, I'm not sure it is worth to change 1000+ lines. > It may be better to set guideline for new submissions. > > Welcome any comments. Generally, more conforming to norms is better. These FOO_ uses are non-conforming. Is there anything other than a one-time cost to apply these? Is the same code used for other platforms?