Re: [PATCH] mm:Avoid soft lockup due to possible attempt of double locking object's lock in __delete_object

Catalin Marinas
2016-08-31T14:35:37Z

On Wed, Aug 31, 2016 at 09:41:23AM -0400, nick wrote:
> On 2016-08-31 03:54 AM, Catalin Marinas wrote:
> > On Tue, Aug 30, 2016 at 02:35:12PM -0400, Nicholas Krause wrote:
> >> This fixes a issue in the current locking logic of the function,
> >> __delete_object where we are trying to attempt to lock the passed
> >> object structure's spinlock again after being previously held
> >> elsewhere by the kmemleak code. Fix this by instead of assuming
> >> we are the only one contending for the object's lock their are
> >> possible other users and create two branches, one where we get
> >> the lock when calling spin_trylock_irqsave on the object's lock
> >> and the other when the lock is held else where by kmemleak.
> >
> > Have you actually got a deadlock that requires this fix?
>
> Yes it fixes when you run this test,
> https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/ipc/msgctl/msgctl10.c.

I haven't read the subject properly, you meant soft lockup, so no
deadlock here. Do you have any kernel message that you can post on the
list, showing the soft lockup?

> >> --- a/mm/kmemleak.c
> >> +++ b/mm/kmemleak.c
> >> @@ -631,12 +631,19 @@ static void __delete_object(struct kmemleak_object *object)
> >>
> >> /*
> >> * Locking here also ensures that the corresponding memory block
> >> - * cannot be freed when it is being scanned.
> >> + * cannot be freed when it is being scanned. Further more the
> >> + * object's lock may have been previously holded by another holder
> >> + * in the kmemleak code, therefore attempt to lock the object's lock
> >> + * before holding it and unlocking it.
> >> */
> >> - spin_lock_irqsave(&object->lock, flags);
> >> - object->flags &= ~OBJECT_ALLOCATED;
> >> - spin_unlock_irqrestore(&object->lock, flags);
> >> - put_object(object);
> >> + if (spin_trylock_irqsave(&object->lock, flags)) {
> >> + object->flags &= ~OBJECT_ALLOCATED;
> >> + spin_unlock_irqrestore(&object->lock, flags);
> >> + put_object(object);
> >> + } else {
> >> + object->flags &= ~OBJECT_ALLOCATED;
> >> + put_object(object);
> >> + }
> >
> > NAK. This lock here is needed, as described in the comment, to prevent
> > an object being freed while it is being scanned. The scan_object()
> > function acquires the same lock and checks for OBJECT_ALLOCATED before
> > accessing the memory (which could be vmalloc'ed for example, so freeing
> > would cause a page fault).
>
> That's the issue, right there. Your double locking in scan_object. If
> you look at the code:
> /*
> * Once the object->lock is acquired, the corresponding memory block
> * cannot be freed (the same lock is acquired in delete_object).
> */
> That test case exposes that issue in the logic, what happens if we are
> running this on separate kernel threads what happens then ...
> deadlock.

There cannot be any deadlock since you can't have two threads on the
same CPU trying to acquire this spinlock, nor any dependency on another
lock that I'm aware of. As for the soft lockup, scan_object() in
kmemleak tries to avoid it by releasing this lock periodically and
calling cond_resched().

--
Catalin