From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932177AbcIGJZH (ORCPT ); Wed, 7 Sep 2016 05:25:07 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36264 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757222AbcIGJZD (ORCPT ); Wed, 7 Sep 2016 05:25:03 -0400 From: Bartosz Golaszewski To: Linus Walleij , Alexandre Courbot , Andy Shevchenko , Vignesh R , Yong Li , Geert Uytterhoeven Cc: linux-gpio , LKML , Bartosz Golaszewski Subject: [PATCH v2 0/5] gpio: pca953x: code refactoring Date: Wed, 7 Sep 2016 11:24:52 +0200 Message-Id: <1473240297-19881-1-git-send-email-bgolaszewski@baylibre.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'm working on converting the pca953x driver to using regmap, but since it's not a trivial task I figured I'd post a couple refactoring patches I did so far for 4.9. The first patch just fixes a couple coding style issues. The second removes a couple unnecessary switches. Last three refactor the read/write_regs functions to avoid if-elses by using function pointers to smaller, specialized routines. Tested with pca9534 and pca9535 chips. v1 -> v2: - constified the offset structures in patch 2/5 Bartosz Golaszewski (5): gpio: pca953x: coding style fixes gpio: pca953x: code shrink gpio: pca953x: refactor pca953x_write_regs() gpio: pca953x: remove an unused variable gpio: pca953x: refactor pca953x_read_regs() drivers/gpio/gpio-pca953x.c | 270 ++++++++++++++++++++++---------------------- 1 file changed, 136 insertions(+), 134 deletions(-) -- 2.7.4