From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756567AbcIGLR4 (ORCPT ); Wed, 7 Sep 2016 07:17:56 -0400 Received: from mga09.intel.com ([134.134.136.24]:19391 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbcIGLRy (ORCPT ); Wed, 7 Sep 2016 07:17:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,296,1470726000"; d="scan'208";a="757974800" Message-ID: <1473247046.11323.37.camel@linux.intel.com> Subject: Re: [PATCH v2 1/5] gpio: pca953x: coding style fixes From: Andy Shevchenko To: Bartosz Golaszewski , Linus Walleij , Alexandre Courbot , Vignesh R , Yong Li , Geert Uytterhoeven Cc: linux-gpio , LKML Date: Wed, 07 Sep 2016 14:17:26 +0300 In-Reply-To: <1473240297-19881-2-git-send-email-bgolaszewski@baylibre.com> References: <1473240297-19881-1-git-send-email-bgolaszewski@baylibre.com> <1473240297-19881-2-git-send-email-bgolaszewski@baylibre.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-09-07 at 11:24 +0200, Bartosz Golaszewski wrote: > pca953x_gpio_set_multiple() has some coding style issues that make it > harder to read. Tweak the code a bit. > I would suggest to make this a last patch in the series. Rationale is that you might have changed same lines by functional changes and the first patch in such cases just makes a noise. More important, easier way to back port if anyone is interested in that. -- Andy Shevchenko Intel Finland Oy