From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756663AbcIGN6y (ORCPT ); Wed, 7 Sep 2016 09:58:54 -0400 Received: from mga07.intel.com ([134.134.136.100]:60603 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752767AbcIGN6v (ORCPT ); Wed, 7 Sep 2016 09:58:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,296,1470726000"; d="scan'208";a="1026316012" Message-ID: <1473256724.11323.72.camel@linux.intel.com> Subject: Re: [PATCH v3 4/5] gpio: pca953x: remove an unused variable From: Andy Shevchenko To: Bartosz Golaszewski , Linus Walleij , Alexandre Courbot , Vignesh R , Yong Li , Geert Uytterhoeven Cc: linux-gpio , LKML Date: Wed, 07 Sep 2016 16:58:44 +0300 In-Reply-To: <1473255472-16090-5-git-send-email-bgolaszewski@baylibre.com> References: <1473255472-16090-1-git-send-email-bgolaszewski@baylibre.com> <1473255472-16090-5-git-send-email-bgolaszewski@baylibre.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-09-07 at 15:37 +0200, Bartosz Golaszewski wrote: > The chip_type variable in struct pca953x_chip is no longer required. > > Remove it. > > - chip->write_regs = chip->chip_type == PCA953X_TYPE ? > - pca953x_write_regs_16 : > - pca957x_write_regs_16; > + if (PCA_CHIP_TYPE(chip->driver_data) == PCA953X_TYPE) > + chip->write_regs = pca953x_write_regs_16; > + else > + chip->write_regs = pca957x_write_regs_16; >   chip->read_regs = pca953x_read_regs_16; I would also move this to previous patch. -- Andy Shevchenko Intel Finland Oy