From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758204AbcIHM1m (ORCPT ); Thu, 8 Sep 2016 08:27:42 -0400 Received: from mga06.intel.com ([134.134.136.31]:40824 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbcIHM1l (ORCPT ); Thu, 8 Sep 2016 08:27:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,300,1470726000"; d="scan'208";a="165819123" Message-ID: <1473337655.11323.94.camel@linux.intel.com> Subject: Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent From: Andy Shevchenko To: Bartosz Golaszewski , Linus Walleij , Alexandre Courbot , Vignesh R , Yong Li , Geert Uytterhoeven Cc: linux-gpio , LKML Date: Thu, 08 Sep 2016 15:27:35 +0300 In-Reply-To: <1473331702-26711-7-git-send-email-bgolaszewski@baylibre.com> References: <1473331702-26711-1-git-send-email-bgolaszewski@baylibre.com> <1473331702-26711-7-git-send-email-bgolaszewski@baylibre.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-09-08 at 12:48 +0200, Bartosz Golaszewski wrote: > The register offset defines for the pca953x and pca957x expander > families should have the same names to better reflect their similar > purposes.   >   chip->regs = &pca957x_regs; >   > - ret = pca953x_read_regs(chip, PCA957X_OUT, chip->reg_output); > + ret = pca953x_read_regs(chip, PCA957X_OUTPUT, chip- > >reg_output); >   if (ret) >   goto out; > - ret = pca953x_read_regs(chip, PCA957X_CFG, chip- > >reg_direction); > + ret = pca953x_read_regs(chip, PCA957X_DIRECTION, chip- > >reg_direction); Bu we may use chip->regs->direction here, right? And output before.  >   if (ret) >   goto out; >   -- Andy Shevchenko Intel Finland Oy