From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938873AbcIHM3g (ORCPT ); Thu, 8 Sep 2016 08:29:36 -0400 Received: from mga05.intel.com ([192.55.52.43]:49063 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933864AbcIHM3e (ORCPT ); Thu, 8 Sep 2016 08:29:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,300,1470726000"; d="scan'208";a="1037025797" Message-ID: <1473337770.11323.95.camel@linux.intel.com> Subject: Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent From: Andy Shevchenko To: Bartosz Golaszewski , Linus Walleij , Alexandre Courbot , Vignesh R , Yong Li , Geert Uytterhoeven Cc: linux-gpio , LKML Date: Thu, 08 Sep 2016 15:29:30 +0300 In-Reply-To: <1473337655.11323.94.camel@linux.intel.com> References: <1473331702-26711-1-git-send-email-bgolaszewski@baylibre.com> <1473331702-26711-7-git-send-email-bgolaszewski@baylibre.com> <1473337655.11323.94.camel@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-09-08 at 15:27 +0300, Andy Shevchenko wrote: > On Thu, 2016-09-08 at 12:48 +0200, Bartosz Golaszewski wrote: > > > > The register offset defines for the pca953x and pca957x expander > > families should have the same names to better reflect their similar > > purposes. > And one more question. If it is done in datasheet as is used currently in the driver I would leave it to be aligned with official documentation. -- Andy Shevchenko Intel Finland Oy