From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: joel@jms.id.au
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] clocksource/drivers/moxart: Replace panic by pr_err
Date: Thu, 8 Sep 2016 15:58:10 +0200 [thread overview]
Message-ID: <1473343090-29208-2-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1473343090-29208-1-git-send-email-daniel.lezcano@linaro.org>
The clksrc-of code is supposed to catch the return code and fail gracefully.
Don't panic on error, but print the error and exit with a relevant error
code.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/clocksource/moxart_timer.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/moxart_timer.c b/drivers/clocksource/moxart_timer.c
index cba25b7..2a8f470 100644
--- a/drivers/clocksource/moxart_timer.c
+++ b/drivers/clocksource/moxart_timer.c
@@ -184,8 +184,10 @@ static int __init moxart_timer_init(struct device_node *node)
} else if (of_device_is_compatible(node, "aspeed,ast2400-timer")) {
timer->t1_enable_val = ASPEED_TIMER1_ENABLE;
timer->t1_disable_val = ASPEED_TIMER1_DISABLE;
- } else
- panic("%s: unknown platform\n", node->full_name);
+ } else {
+ pr_err("%s: unknown platform\n", node->full_name);
+ return -EINVAL;
+ }
timer->count_per_tick = DIV_ROUND_CLOSEST(pclk, HZ);
--
1.9.1
next prev parent reply other threads:[~2016-09-08 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 13:58 [PATCH 1/2] clocksource/drivers/moxart: Replace setup_irq by request_irq Daniel Lezcano
2016-09-08 13:58 ` Daniel Lezcano [this message]
2016-09-12 1:46 ` [PATCH 2/2] clocksource/drivers/moxart: Replace panic by pr_err Joel Stanley
2016-09-12 1:46 ` [PATCH 1/2] clocksource/drivers/moxart: Replace setup_irq by request_irq Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473343090-29208-2-git-send-email-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).