From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S941349AbcIHQe1 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Sep 2016 12:34:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57768 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S941095AbcIHQeX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Sep 2016 12:34:23 -0400
Message-ID: <1473352456.21193.8.camel@redhat.com>
Subject: Re: [PATCH v10 3/4] ARM64: ACPI: enable ACPI_SPCR_TABLE
From: Mark Salter <msalter@redhat.com>
To: Will Deacon <will.deacon@arm.com>,
        Aleksey Makarov <amakarov.linux@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
        Aleksey Makarov <aleksey.makarov@linaro.org>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        "Zheng, Lv" <lv.zheng@intel.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Russell King <linux@arm.linux.org.uk>,
        Peter Hurley <peter@hurleysoftware.com>,
        Graeme Gregory <graeme.gregory@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-kernel@vger.kernel.org, Leif Lindholm <leif.lindholm@linaro.org>,
        linux-acpi@vger.kernel.org, Yury Norov <ynorov@caviumnetworks.com>,
        Christopher Covington <cov@codeaurora.org>,
        linux-serial@vger.kernel.org, Al Stone <ahs3@redhat.com>,
        linux-arm-kernel@lists.infradead.org, Len Brown <lenb@kernel.org>
Date: Thu, 08 Sep 2016 12:34:16 -0400
In-Reply-To: <20160908111654.GH1493@arm.com>
References: <20160905123617.18775-1-aleksey.makarov@linaro.org>
         <20160905123617.18775-4-aleksey.makarov@linaro.org>
         <7e5486cc-4080-2d1e-8f6d-98874379887d@gmail.com>
         <20160908111654.GH1493@arm.com>
Organization: Red Hat, Inc
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 08 Sep 2016 16:34:22 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2016-09-08 at 12:16 +0100, Will Deacon wrote:
> On Wed, Sep 07, 2016 at 12:30:19PM +0300, Aleksey Makarov wrote:
> > 
> > 
> > On 09/05/2016 03:36 PM, Aleksey Makarov wrote:
> > > 
> > > SBBR mentions SPCR as a mandatory ACPI table.  So enable it for ARM64
> > > 
> > > Earlycon should be set up as early as possible.  ACPI boot tables are
> > > mapped in arch/arm64/kernel/acpi.c:acpi_boot_table_init() that
> > > is called from setup_arch() and that's where we parse SPCR.
> > > So it has to be opted-in per-arch.
> > > 
> > > When ACPI_SPCR_TABLE is defined initialization of DT earlycon is
> > > deferred until the DT/ACPI decision is done.  Initialize DT earlycon
> > > if ACPI is disabled.
> > Hi Will, Catalin,
> > 
> > Can you review this patch and consider ACKing it please?
> Hanjun, Al, Mark, Graeme -- any comments on this?
> 
> Will

I think there is a problem still with systems using 32-bit access to 8250
UARTs (i.e. Mustang) but that will need a DBG2 table spec change and
followup patch to resolve.