From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752699AbcIIGep (ORCPT ); Fri, 9 Sep 2016 02:34:45 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:35558 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500AbcIIGef (ORCPT ); Fri, 9 Sep 2016 02:34:35 -0400 From: Jia He To: netdev@vger.kernel.org Cc: linux-sctp@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , Vlad Yasevich , Neil Horman , Steffen Klassert , Herbert Xu , marcelo.leitner@gmail.com, Jia He Subject: [RFC PATCH v3 4/7] proc: Reduce cache miss in sctp_snmp_seq_show Date: Fri, 9 Sep 2016 14:33:59 +0800 Message-Id: <1473402842-1987-5-git-send-email-hejianet@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1473402842-1987-1-git-send-email-hejianet@gmail.com> References: <1473402842-1987-1-git-send-email-hejianet@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is to use the generic interface snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Signed-off-by: Jia He --- net/sctp/proc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/sctp/proc.c b/net/sctp/proc.c index ef8ba77..0487c01 100644 --- a/net/sctp/proc.c +++ b/net/sctp/proc.c @@ -75,11 +75,15 @@ static int sctp_snmp_seq_show(struct seq_file *seq, void *v) { struct net *net = seq->private; int i; + unsigned long buff[SCTP_MIB_MAX]; + memset(buff, 0, sizeof(unsigned long) * SCTP_MIB_MAX); + + snmp_get_cpu_field_batch(buff, sctp_snmp_list, + net->sctp.sctp_statistics); for (i = 0; sctp_snmp_list[i].name != NULL; i++) seq_printf(seq, "%-32s\t%ld\n", sctp_snmp_list[i].name, - snmp_fold_field(net->sctp.sctp_statistics, - sctp_snmp_list[i].entry)); + buff[i]); return 0; } -- 1.8.3.1