From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754225AbcIILat (ORCPT ); Fri, 9 Sep 2016 07:30:49 -0400 Received: from mga04.intel.com ([192.55.52.120]:4296 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753299AbcIILar (ORCPT ); Fri, 9 Sep 2016 07:30:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,304,1470726000"; d="scan'208";a="1047824411" Message-ID: <1473420644.11323.128.camel@linux.intel.com> Subject: Re: [PATCH v3 3/3] intel-mid: Move boundry check to the start of init code From: Andy Shevchenko To: Kuppuswamy Sathyanarayanan , wharms@bfs.de Cc: dan.carpenter@oracle.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, david.a.cohen@linux.intel.com Date: Fri, 09 Sep 2016 14:30:44 +0300 In-Reply-To: References: <1473210255-227672-1-git-send-email-sathyanarayanan.kuppuswamy@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-09-08 at 19:07 -0700, Kuppuswamy Sathyanarayanan wrote: > Moved the instance boundary check to the start of the pcal9555a > platform init code. This will prevent unnecessary initialization > on instance boundary error. I don't see how it makes any better. I would drop this patch. > > Signed-off-by: Kuppuswamy Sathyanarayanan linux.intel.com> > --- >  arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c | 12 > ++++++------ >  1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/platform/intel- > mid/device_libs/platform_pcal9555a.c b/arch/x86/platform/intel- > mid/device_libs/platform_pcal9555a.c > index cde764e..4e5dd95 100644 > --- a/arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c > +++ b/arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c > @@ -34,6 +34,12 @@ static void __init *pcal9555a_platform_data(void > *info) >   char intr_pin_name[SFI_NAME_LEN + 1]; >   int gpio_base, intr; >   > + if (nr >= PCAL9555A_NUM) { > + pr_err("%s: Too many instances, only %d supported\n", > __func__, > +        PCAL9555A_NUM); > + return ERR_PTR(-ENOMEM); > + } > + >   snprintf(base_pin_name, sizeof(base_pin_name), "%s_base", > type); >   snprintf(intr_pin_name, sizeof(intr_pin_name), "%s_int", > type); >   > @@ -47,12 +53,6 @@ static void __init *pcal9555a_platform_data(void > *info) >   return NULL; >   } >   > - if (nr >= PCAL9555A_NUM) { > - pr_err("%s: Too many instances, only %d supported\n", > __func__, > -        PCAL9555A_NUM); > - return ERR_PTR(-ENOMEM); > - } > - >   pcal9555a = &pcal9555a_pdata[nr++]; >   pcal9555a->gpio_base = gpio_base; >   -- Andy Shevchenko Intel Finland Oy