From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753665AbcIIRVr (ORCPT ); Fri, 9 Sep 2016 13:21:47 -0400 Received: from mail-co1nam03on0102.outbound.protection.outlook.com ([104.47.40.102]:27728 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752088AbcIIRVm (ORCPT ); Fri, 9 Sep 2016 13:21:42 -0400 From: "Kani, Toshimitsu" To: "kirill.shutemov@linux.intel.com" CC: "hughd@google.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "adilger.kernel@dilger.ca" , "mike.kravetz@oracle.com" , "dan.j.williams@intel.com" , "mawilcox@microsoft.com" , "akpm@linux-foundation.org" , "linux-nvdimm@lists.01.org" , "kirill@shutemov.name" , "linux-fsdevel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "tytso@mit.edu" , "david@fromorbit.com" , "jack@suse.cz" Subject: Re: [PATCH v4 RESEND 0/2] Align mmap address for DAX pmd mappings Thread-Topic: [PATCH v4 RESEND 0/2] Align mmap address for DAX pmd mappings Thread-Index: AQHSAilHX/y+euft+0Ox/nTogkvaQaBgaSEAgAAMDQCAAAffAIAO/huAgAAv7YCAAJ/ZAIAA3jkAgABPfwA= Date: Fri, 9 Sep 2016 17:21:40 +0000 Message-ID: <1473441640.2092.74.camel@hpe.com> References: <1472497881-9323-1-git-send-email-toshi.kani@hpe.com> <20160829204842.GA27286@node.shutemov.name> <1472506310.1532.47.camel@hpe.com> <1472508000.1532.59.camel@hpe.com> <20160908105707.GA17331@node> <1473342519.2092.42.camel@hpe.com> <1473376846.2092.69.camel@hpe.com> <20160909123608.GA75965@black.fi.intel.com> In-Reply-To: <20160909123608.GA75965@black.fi.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.219.163.9] x-ms-office365-filtering-correlation-id: 1bce198b-58b2-431d-d86c-08d3d8d5c341 x-microsoft-exchange-diagnostics: 1;CS1PR84MB0007;6:dTFbsawmYNjThdssyz2vnUvroSJfFd8RHdTciISS4yWSd1qYhr9hoY/Q4jzDvGNWVIWrE/T2prxhQJujk1/l6QVCxzgjOaK6vIDhS63PwDdxo2yHeh54KBEd9rWeY/4S7MazrxWsKxpxn6AMx22JeTW/DWb03+ul24S8mb/aMr54CHKec3CY+qsuJot0wUf52OYvYyU2Z1pfmTp8EkAznVawhzr3HvRbXVzcSx+sUWZtyPP48GLOdhYWHJkvlFU9WZqU8L3i7d4iscXq8Gr8tQIAXSiFEx0PMNCP6GuguMM6EsiOIr4fPlLi1P0NROqABdz8gii5Nb5Mq3+ckWTxWw==;5:LbmOeY33QPMcMxztigeMpuxof+f3sYxiayuDsU+RWHXfmd807I5C1xQlxb6dVnprOn1LlgzWUwfOJuwvguQcuqMze/PvCmFdHTnz425C5cynzSXk4jCTCRZvUQh4KfyN8QuwugGI1jDrcScqSUMGHA==;24:fJ4C56nUVywtryd3jg/bLl4QbZtfidecKlJI9cfCVdJE9SQ/4LMeTRLH5HS0aofWG6IU/Bt6g5Wx6oc5PFqgwZERypVLSvfUPJAvXMV7asA=;7:/ADgbodAokw7RQM5/qoC8f7hs4ye81yaXQKAQwxhb/HDrOPUfyoh0JNePxdcl7WxZxTgcwH6dRE/A/bDbNRsf2lZ5sdyvJr7HCved4tmgdUnlNEDr4doHV/yuZtmhU/ev12gJVGvflqhuU8Bwsb6gGgnsethlYPWkaNhiwNuqxMzNjiAjYUh/37SVcVP7yUc4cq3EFfHHc2naklsGnGcH2/HmWrzzZDE6o77Y1KR5P4euROAM/dbm6n1IWO3Vi+8 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0007; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(42068640409301); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:CS1PR84MB0007;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0007; x-forefront-prvs: 00603B7EEF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(24454002)(189002)(377424004)(199003)(305945005)(586003)(68736007)(33646002)(2501003)(10400500002)(11100500001)(15975445007)(86362001)(36756003)(66066001)(122556002)(5660300001)(77096005)(2950100001)(2900100001)(97736004)(93886004)(81166006)(81156014)(2351001)(8666005)(3280700002)(105586002)(101416001)(8676002)(76176999)(54356999)(106116001)(102836003)(92566002)(6116002)(3846002)(99286002)(50986999)(106356001)(4326007)(110136002)(2906002)(7416002)(103116003)(189998001)(87936001)(8936002)(19580395003)(5002640100001)(7846002)(7736002)(3660700001);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0007;H:CS1PR84MB0005.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2016 17:21:40.2585 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0007 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u89HLrVX003032 On Fri, 2016-09-09 at 15:36 +0300, Kirill A. Shutemov wrote: > On Thu, Sep 08, 2016 at 11:21:46PM +0000, Kani, Toshimitsu wrote: > > > > On Thu, 2016-09-08 at 07:48 -0600, Kani, Toshimitsu wrote: > > > > > > On Thu, 2016-09-08 at 13:57 +0300, Kirill A. Shutemov wrote: > > > > > > > > On Mon, Aug 29, 2016 at 10:00:43PM +0000, Kani, Toshimitsu > > > > wrote: > >  : > > > > > Looking further, these shmem_huge handlings only check pre- > > > > > conditions.  So, we should be able to make shmem_get_unmapped > > > > > _are a() as a wrapper, which checks such shmem-specific > > > > > conitions, and then call __thp_get_unmapped_area() for the > > > > > actual work.  All DAX-specific checks are performed in > > > > > thp_get_unmapped_area() as well.  We can make > > > > >  __thp_get_unmapped_area() as a common > > > > > function. > > > > > > > > > > I'd prefer to make such change as a separate item, > > > > > > > > Do you have plan to submit such change? > > > > > > Yes, I will submit the change once I finish testing. > > > > I found a bug in the current code, and need some clarification. > >  The if-statement below is reverted. > > > > Yeah. It was repored by Hillf[1]. The fixup got lost. :( > > Could you post a proper patch with the fix? > > I would be nice to credit Hillf there too. > > [1] http://lkml.kernel.org/r/054f01d1c86f$2994d5c0$7cbe8140$@alibaba- > inc.com Yes, I will submit the fix as well. I will not change the default value of sbinfo->huge in this fix.  So, user will have to specify "huge=" option to enable huge page mappings.  If this is not desireable, we will need a separate patch. Thanks, -Toshi