From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753895AbcIISzv (ORCPT ); Fri, 9 Sep 2016 14:55:51 -0400 Received: from smtprelay0017.hostedemail.com ([216.40.44.17]:38120 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752015AbcIISzt (ORCPT ); Fri, 9 Sep 2016 14:55:49 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2736:2828:3138:3139:3140:3141:3142:3167:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:4321:4605:5007:7903:8957:10004:10400:10848:11026:11232:11473:11658:11914:12296:12740:13069:13132:13231:13311:13357:13439:14096:14097:14659:14721:21080:21451:30012:30034:30054:30064:30069:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: heat59_32531b097b42f X-Filterd-Recvd-Size: 2569 Message-ID: <1473447344.10509.3.camel@perches.com> Subject: Re: [PATCH] ACPICA / Interpreter: Remove redundant newline From: Joe Perches To: Borislav Petkov , "Moore, Robert" Cc: LKML , "Zheng, Lv" , "Wysocki, Rafael J" , Len Brown , "linux-acpi@vger.kernel.org" , "devel@acpica.org" Date: Fri, 09 Sep 2016 11:55:44 -0700 In-Reply-To: <20160909184042.srv6jrio6s5umear@pd.tnic> References: <20160909161253.30952-1-bp@alien8.de> <94F2FBAB4432B54E8AACC7DFDE6C92E37E4F34B4@ORSMSX110.amr.corp.intel.com> <20160909184042.srv6jrio6s5umear@pd.tnic> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-09-09 at 20:40 +0200, Borislav Petkov wrote: > On Fri, Sep 09, 2016 at 06:26:17PM +0000, Moore, Robert wrote: > > Is this a big deal? > > We do this on purpose for AcpiExec, to make the screen output more readable. [] > What do you mean "big deal"? All other ACPI_INFO calls don't have a "\n" > at the end except this one. How does one "\n" make some output more > readable? Blank lines in logging/dmesg generally don't add value. I would prefer if the unnecessary double parentheses also were removed in these macro uses and ##__VA_ARGS__ was used instead. /* * Error reporting. Callers module and line number are inserted by AE_INFO, * the plist contains a set of parens to allow variable-length lists. * These macros are used for both the debug and non-debug versions of the code. */ #define ACPI_INFO(plist) acpi_info plist #define ACPI_WARNING(plist) acpi_warning plist #define ACPI_EXCEPTION(plist) acpi_exception plist #define ACPI_ERROR(plist) acpi_error plist #define ACPI_BIOS_WARNING(plist) acpi_bios_warning plist #define ACPI_BIOS_ERROR(plist) acpi_bios_error plist It would also be good if format/argument verification was done here and in the non-debug macro variants. #define ACPI_INFO(plist) #define ACPI_WARNING(plist) #define ACPI_EXCEPTION(plist) #define ACPI_ERROR(plist) #define ACPI_BIOS_WARNING(plist) #define ACPI_BIOS_ERROR(plist)