From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757287AbcILSPA (ORCPT ); Mon, 12 Sep 2016 14:15:00 -0400 Received: from smtprelay0152.hostedemail.com ([216.40.44.152]:44122 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752793AbcILSO6 (ORCPT ); Mon, 12 Sep 2016 14:14:58 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:4321:4605:5007:10004:10400:10848:11026:11658:11914:12043:12048:12296:12740:13069:13311:13357:13439:13894:14659:14721:21080:21433:21451:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: corn15_de949124c055 X-Filterd-Recvd-Size: 1954 Message-ID: <1473704094.11006.21.camel@perches.com> Subject: Re: [PATCH] staging: rtl8712: fix coding style error reported from checkpatch From: Joe Perches To: Omri Arad , Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 12 Sep 2016 11:14:54 -0700 In-Reply-To: <1473703345-14320-1-git-send-email-omriarad3@gmail.com> References: <1473703345-14320-1-git-send-email-omriarad3@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-09-12 at 21:02 +0300, Omri Arad wrote: [] > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c [] > @@ -1976,9 +1976,9 @@ static int r871x_get_ap_info(struct net_device *dev, >   if (pdata->length >= 32) { >   if (copy_from_user(data, pdata->pointer, 32)) >   return -EINVAL; > - data[32] = 0; > + data[32] = 0; >   } else { > - return -EINVAL; > + return -EINVAL; >   } >   spin_lock_irqsave(&(pmlmepriv->scanned_queue.lock), irqL); >   phead = &queue->queue; Please don't blindly follow checkpatch messages but look to see how the code can be improved beyond what checkpatch emits. Perhaps more pleasant to read would be to rewrite this block like: if (pdata->length < 32 || copy_from_user(data, pdata->pointer, 32)) return -EINVAL; data[32] = 0; Perhaps as well the literal 32 uses here and the 33 in the declaration of data uses should be some #define or sizeof or ARRAY_SIZE.