public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue
       [not found] <CAFrQyDGBgef3Nko84BcC9awPCP8+-wrpH2wGZmcfGEctuC31nA@mail.gmail.com>
@ 2016-09-12 18:07 ` Ian Abbott
  2016-09-12 18:17   ` Joe Perches
  0 siblings, 1 reply; 2+ messages in thread
From: Ian Abbott @ 2016-09-12 18:07 UTC (permalink / raw)
  To: Namrata A Shettar, hsweeten, gregkh, badbuddha91, devel,
	linux-kernel

On 12/09/16 18:29, Namrata A Shettar wrote:
> This patch fixes the checkpatch.pl <http://checkpatch.pl> issue:
> -Please don't use multiple blank lines
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com
> <mailto:namrataashettar@gmail.com>>
> ---
>  drivers/staging/comedi/comedi_pcmcia.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
> b/drivers/staging/comedi/comedi_pcmcia.c
> index d7072a5..ec8a0ad 100644
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
>  #include <linux/module.h>
>  #include <linux/kernel.h>
> -
>  #include "comedi_pcmcia.h"
>
>  /**

But there is only one blank line, so why the warning about multiple 
blank lines?

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue
  2016-09-12 18:07 ` [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue Ian Abbott
@ 2016-09-12 18:17   ` Joe Perches
  0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2016-09-12 18:17 UTC (permalink / raw)
  To: Ian Abbott, Namrata A Shettar, hsweeten, gregkh, badbuddha91,
	devel, linux-kernel

On Mon, 2016-09-12 at 19:07 +0100, Ian Abbott wrote:
> On 12/09/16 18:29, Namrata A Shettar wrote:
> > This patch fixes the checkpatch.pl <http://checkpatch.pl> issue:
> -Please don't use multiple blank lines
[]
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
[]
> @@ -18,7 +18,6 @@
> 
>  #include <linux/module.h>
>  #include <linux/kernel.h>
> -
>  #include "comedi_pcmcia.h"
> 
>  /**
> 
> 
> But there is only one blank line, so why the warning about multiple 
> blank lines?

checkpatch doesn't emit a warning here.

Also the http://checkpatch.pl link is incorrect

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-12 18:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CAFrQyDGBgef3Nko84BcC9awPCP8+-wrpH2wGZmcfGEctuC31nA@mail.gmail.com>
2016-09-12 18:07 ` [PATCH] staging: comedi: comedi_pcmcia: Fixes multiple blank lines issue Ian Abbott
2016-09-12 18:17   ` Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox