From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756044AbcINC3Y (ORCPT ); Tue, 13 Sep 2016 22:29:24 -0400 Received: from smtprelay0218.hostedemail.com ([216.40.44.218]:43429 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753522AbcINC3W (ORCPT ); Tue, 13 Sep 2016 22:29:22 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3872:3873:3874:4321:5007:7903:10004:10400:10848:11232:11658:11914:12740:12760:13069:13311:13357:13439:14181:14659:14721:21080:30054:30060:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:17,LUA_SUMMARY:none X-HE-Tag: band68_174f1a8dd5101 X-Filterd-Recvd-Size: 1727 Message-ID: <1473820159.32273.18.camel@perches.com> Subject: Re: [PATCH] crypto: squash lines for simple wrapper functions From: Joe Perches To: Masahiro Yamada Cc: linux-crypto@vger.kernel.org, Herbert Xu , Linux Kernel Mailing List , "David S. Miller" Date: Tue, 13 Sep 2016 19:29:19 -0700 In-Reply-To: References: <1473708474-32359-1-git-send-email-yamada.masahiro@socionext.com> <1473709457.11006.31.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-09-14 at 11:10 +0900, Masahiro Yamada wrote: > 2016-09-13 4:44 GMT+09:00 Joe Perches : > > On Tue, 2016-09-13 at 04:27 +0900, Masahiro Yamada wrote: > > > Remove unneeded variables and assignments. > > Was this found by visual inspection or some tool? > > If it's via a tool, it's good to mention that in the changelog. > I used Coccinelle, but I did not mention it > in case somebody may say "then, please provide your semantic patch". > As a Coccinelle beginner, I do not want to expose my stupid semantic patch. If you get it "exposed", you'd likely learn something from others that would give a few suggestions/tips on how to improve it.