From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762061AbcINHwq (ORCPT ); Wed, 14 Sep 2016 03:52:46 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:40911 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761550AbcINHpF (ORCPT ); Wed, 14 Sep 2016 03:45:05 -0400 From: Kishon Vijay Abraham I To: CC: , Subject: [PATCH 18/51] phy: rockchip-inno-usb2: add COMMON_CLK dependency Date: Wed, 14 Sep 2016 13:13:59 +0530 Message-ID: <1473839072-5673-19-git-send-email-kishon@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1473839072-5673-1-git-send-email-kishon@ti.com> References: <1473839072-5673-1-git-send-email-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Wang On kernel builds without COMMON_CLK, the newly added rockchip-inno-usb2 driver fails to build: drivers/phy/phy-rockchip-inno-usb2.c:124:16: error: field 'clk480m_hw' has incomplete type struct clk_hw clk480m_hw; In file included from include/linux/clk.h:16:0 from drivers/phy/phy-rockchip-inno-usb2.c:17: include/linux/kernel.h:831:48: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ... ... Signed-off-by: Frank Wang Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Guenter Roeck Reviewed-by: Heiko Stuebner --- drivers/phy/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 46e5536..8cf6c3d 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -370,6 +370,7 @@ config PHY_ROCKCHIP_USB config PHY_ROCKCHIP_INNO_USB2 tristate "Rockchip INNO USB2PHY Driver" depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF + depends on COMMON_CLK select GENERIC_PHY help Support for Rockchip USB2.0 PHY with Innosilicon IP block. -- 1.7.9.5