From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752352AbcIORch (ORCPT ); Thu, 15 Sep 2016 13:32:37 -0400 Received: from smtprelay0237.hostedemail.com ([216.40.44.237]:53555 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751529AbcIORca (ORCPT ); Thu, 15 Sep 2016 13:32:30 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3867:3871:3872:3874:4321:5007:10004:10400:10848:11232:11658:11914:12740:12760:13069:13255:13311:13357:13439:14659:21080:21433:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: wax78_6cd012959a45f X-Filterd-Recvd-Size: 1328 Message-ID: <1473960746.32273.62.camel@perches.com> Subject: Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test From: Joe Perches To: Sergio Paracuellos , Greg KH Cc: bhumirks@gmail.com, jrickertkc@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Thu, 15 Sep 2016 10:32:26 -0700 In-Reply-To: <57DAD8E0.1050306@gmail.com> References: <1473949794-9708-1-git-send-email-sergio.paracuellos@gmail.com> <20160915145131.GA26016@kroah.com> <57DAD8E0.1050306@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-09-15 at 19:22 +0200, Sergio Paracuellos wrote: > That's true. It seems that checkpatch script is getting a false > positive. Just trying to do checkpatch happy. Sorry for inconvenience. Keeping the style consistent instead of taking the simplest path to quiet the checkpatch messages is better. Making N, min_N, max_N all lower case would be better.