From: Tejun Heo <tj@kernel.org>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, jiangshanlai@gmail.com,
akpm@linux-foundation.org, kernel-team@fb.com,
Tejun Heo <tj@kernel.org>, Qiao Zhou <qiaozhou@asrmicro.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: [PATCH 4/7] power, workqueue: remove keventd_up() usage
Date: Thu, 15 Sep 2016 15:30:18 -0400 [thread overview]
Message-ID: <1473967821-24363-5-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1473967821-24363-1-git-send-email-tj@kernel.org>
Now that workqueue can handle work item queueing/cancelling from very
early during boot, there is no need to gate cancel_delayed_work_sync()
while !keventd_up(). Remove it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Qiao Zhou <qiaozhou@asrmicro.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
Hello,
This change depends on an earlier workqueue patch and is followed by a
patch to remove keventd_up(). It'd be great if it can be routed
through the wq/for-4.9 branch.
Thanks.
kernel/power/qos.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/kernel/power/qos.c b/kernel/power/qos.c
index 168ff44..97b0df7 100644
--- a/kernel/power/qos.c
+++ b/kernel/power/qos.c
@@ -482,16 +482,7 @@ void pm_qos_update_request(struct pm_qos_request *req,
return;
}
- /*
- * This function may be called very early during boot, for example,
- * from of_clk_init(), where irq needs to stay disabled.
- * cancel_delayed_work_sync() assumes that irq is enabled on
- * invocation and re-enables it on return. Avoid calling it until
- * workqueue is initialized.
- */
- if (keventd_up())
- cancel_delayed_work_sync(&req->work);
-
+ cancel_delayed_work_sync(&req->work);
__pm_qos_update_request(req, new_value);
}
EXPORT_SYMBOL_GPL(pm_qos_update_request);
--
2.7.4
next prev parent reply other threads:[~2016-09-15 19:31 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 19:30 [PATCHSET wq/for-4.9] workqueue: make workqueue available very early during boot Tejun Heo
2016-09-15 19:30 ` [PATCH 1/7] workqueue: make workqueue available " Tejun Heo
2016-09-17 17:23 ` [PATCH v2 " Tejun Heo
[not found] ` <87twck5wqo.fsf@concordia.ellerman.id.au>
2016-10-10 11:17 ` Oops on Power8 (was Re: [PATCH v2 1/7] workqueue: make workqueue available early during boot) Balbir Singh
2016-10-10 12:53 ` Tejun Heo
2016-10-10 13:22 ` Balbir Singh
2016-10-10 13:02 ` Tejun Heo
2016-10-10 13:14 ` Tejun Heo
2016-10-11 11:22 ` Michael Ellerman
2016-10-11 12:21 ` Balbir Singh
2016-10-14 15:08 ` Tejun Heo
2016-10-15 3:43 ` Balbir Singh
2016-10-14 15:07 ` Tejun Heo
2016-10-15 1:25 ` Balbir Singh
2016-10-15 9:48 ` Michael Ellerman
2016-10-17 18:13 ` Tejun Heo
2016-10-17 12:24 ` Michael Ellerman
2016-10-17 12:51 ` Balbir Singh
2016-10-18 2:35 ` Michael Ellerman
2016-10-17 18:15 ` Tejun Heo
2016-10-17 19:30 ` Tejun Heo
2016-10-18 4:37 ` Michael Ellerman
2016-10-18 18:58 ` Tejun Heo
2016-10-19 11:16 ` Michael Ellerman
2016-10-19 16:15 ` [PATCH wq/for-4.10] workqueue: move wq_numa_init() to workqueue_init() Tejun Heo
2016-09-15 19:30 ` [PATCH 2/7] mce, workqueue: remove keventd_up() usage Tejun Heo
2016-09-17 7:56 ` Borislav Petkov
2016-09-17 17:24 ` Tejun Heo
2016-09-17 20:26 ` Borislav Petkov
2016-09-15 19:30 ` [PATCH 3/7] tty, " Tejun Heo
2016-09-15 19:30 ` Tejun Heo [this message]
2016-09-15 23:55 ` [PATCH 4/7] power, " Rafael J. Wysocki
2016-09-15 19:30 ` [PATCH 5/7] slab, " Tejun Heo
2016-09-22 8:01 ` Joonsoo Kim
2016-09-15 19:30 ` [PATCH 6/7] debugobj, " Tejun Heo
2016-09-15 21:19 ` Thomas Gleixner
2016-09-15 19:30 ` [PATCH 7/7] workqueue: remove keventd_up() Tejun Heo
2016-09-15 19:51 ` [PATCHSET wq/for-4.9] workqueue: make workqueue available very early during boot Linus Torvalds
2016-09-16 19:51 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473967821-24363-5-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jiangshanlai@gmail.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qiaozhou@asrmicro.com \
--cc=rafael.j.wysocki@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).