From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932219AbcIOTbF (ORCPT ); Thu, 15 Sep 2016 15:31:05 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:34046 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754147AbcIOTak (ORCPT ); Thu, 15 Sep 2016 15:30:40 -0400 From: Tejun Heo To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, jiangshanlai@gmail.com, akpm@linux-foundation.org, kernel-team@fb.com, Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , linux-mm@kvack.org Subject: [PATCH 5/7] slab, workqueue: remove keventd_up() usage Date: Thu, 15 Sep 2016 15:30:19 -0400 Message-Id: <1473967821-24363-6-git-send-email-tj@kernel.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1473967821-24363-1-git-send-email-tj@kernel.org> References: <1473967821-24363-1-git-send-email-tj@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that workqueue can handle work item queueing from very early during boot, there is no need to gate schedule_delayed_work_on() while !keventd_up(). Remove it. Signed-off-by: Tejun Heo Cc: Christoph Lameter Cc: Pekka Enberg Cc: David Rientjes Cc: Joonsoo Kim Cc: Andrew Morton Cc: linux-mm@kvack.org --- Hello, This change depends on an earlier workqueue patch and is followed by a patch to remove keventd_up(). It'd be great if it can be routed through the wq/for-4.9 branch. Thanks. mm/slab.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/mm/slab.c b/mm/slab.c index b672710..dc69b6b 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -550,12 +550,7 @@ static void start_cpu_timer(int cpu) { struct delayed_work *reap_work = &per_cpu(slab_reap_work, cpu); - /* - * When this gets called from do_initcalls via cpucache_init(), - * init_workqueues() has already run, so keventd will be setup - * at that time. - */ - if (keventd_up() && reap_work->work.func == NULL) { + if (reap_work->work.func == NULL) { init_reap_node(cpu); INIT_DEFERRABLE_WORK(reap_work, cache_reap); schedule_delayed_work_on(cpu, reap_work, -- 2.7.4