From: Heiko Stuebner <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, tomeu.vizoso@collabora.com,
wxt@rock-chips.com, rjw@rjwysocki.net,
Heiko Stuebner <heiko@sntech.de>
Subject: [PATCH 0/2] soc: rockchip: fix probe error path in power-domain driver
Date: Fri, 16 Sep 2016 00:14:37 +0200 [thread overview]
Message-ID: <1473977679-18649-1-git-send-email-heiko@sntech.de> (raw)
A recent change to generic power-domains revealed that the rockchip
driver cannot safely fail it's probe. Also pm_genpd_init creates a
situation where a probe error leads to the generic power-domains
accessing already freed data.
The reason for us finding this issue (holes in power-domain lists), will
get fixed in the generic power-domains, but the fixes below will only
work after the newly added genpd-removal code got merged.
Therefore I hope to remember to send the two patches below as fix after
4.9-rc1.
Alternatively Rafael could include them into his branch directly.
Heiko Stuebner (1):
soc: rockchip: power-domain: use pm_genpd_remove in error cleanup
Tomeu Vizoso (1):
soc: rockchip: power-domain: Handle errors from
of_genpd_add_provider_onecell
drivers/soc/rockchip/pm_domains.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
--
2.8.1
next reply other threads:[~2016-09-15 22:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 22:14 Heiko Stuebner [this message]
2016-09-15 22:14 ` [PATCH 1/2] soc: rockchip: power-domain: use pm_genpd_remove in error cleanup Heiko Stuebner
2016-09-15 22:14 ` [PATCH 2/2] soc: rockchip: power-domain: Handle errors from of_genpd_add_provider_onecell Heiko Stuebner
2016-11-01 22:50 ` [PATCH 0/2] soc: rockchip: fix probe error path in power-domain driver Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473977679-18649-1-git-send-email-heiko@sntech.de \
--to=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tomeu.vizoso@collabora.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox