From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756636AbcIOWO5 (ORCPT ); Thu, 15 Sep 2016 18:14:57 -0400 Received: from gloria.sntech.de ([95.129.55.99]:54344 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755216AbcIOWOt (ORCPT ); Thu, 15 Sep 2016 18:14:49 -0400 From: Heiko Stuebner To: linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomeu.vizoso@collabora.com, wxt@rock-chips.com, rjw@rjwysocki.net, Heiko Stuebner Subject: [PATCH 2/2] soc: rockchip: power-domain: Handle errors from of_genpd_add_provider_onecell Date: Fri, 16 Sep 2016 00:14:39 +0200 Message-Id: <1473977679-18649-3-git-send-email-heiko@sntech.de> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1473977679-18649-1-git-send-email-heiko@sntech.de> References: <1473977679-18649-1-git-send-email-heiko@sntech.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomeu Vizoso It was a bit surprising that the device was reported to have probed just fine, but the provider hadn't been registered. So handle any errors when registering the provider and fail the probe accordingly. Signed-off-by: Tomeu Vizoso Cc: Caesar Wang Signed-off-by: Heiko Stuebner --- unchanged from Tomeu's single-patch drivers/soc/rockchip/pm_domains.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/soc/rockchip/pm_domains.c b/drivers/soc/rockchip/pm_domains.c index 241df213..2fd0c89 100644 --- a/drivers/soc/rockchip/pm_domains.c +++ b/drivers/soc/rockchip/pm_domains.c @@ -636,7 +636,11 @@ static int rockchip_pm_domain_probe(struct platform_device *pdev) goto err_out; } - of_genpd_add_provider_onecell(np, &pmu->genpd_data); + error = of_genpd_add_provider_onecell(np, &pmu->genpd_data); + if (error) { + dev_err(dev, "failed to add provider: %d\n", error); + goto err_out; + } return 0; -- 2.8.1