From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: [tip regression] efi: Allow drivers to reserve boot services forever == toxic
Date: Fri, 16 Sep 2016 08:05:12 +0200 [thread overview]
Message-ID: <1474005912.3930.10.camel@gmail.com> (raw)
Hi Matt,
My workstation started instant rebooting with tip. I bisected it to..
efi/esrt: Use efi_mem_reserve() and avoid a kmalloc()
..but seems it's really $subject, as box works fine with the below.
---
drivers/firmware/efi/efi.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -415,6 +415,7 @@ void __init efi_mem_reserve(phys_addr_t
{
if (!memblock_is_region_reserved(addr, size))
memblock_reserve(addr, size);
+ else
/*
* Some architectures (x86) reserve all boot services ranges
No idea what's going boom down in efi_arch_mem_reserve().
next reply other threads:[~2016-09-16 6:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 6:05 Mike Galbraith [this message]
2016-09-16 9:31 ` [tip regression] efi: Allow drivers to reserve boot services forever == toxic Matt Fleming
2016-09-16 10:00 ` Mike Galbraith
2016-09-16 14:30 ` Matt Fleming
2016-09-16 14:45 ` Mark Rutland
2016-09-16 18:26 ` Mike Galbraith
2016-09-19 8:56 ` Mark Rutland
2016-09-16 16:34 ` Mike Galbraith
2016-09-17 19:58 ` Matt Fleming
2016-09-18 6:09 ` Mike Galbraith
2016-09-19 11:15 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474005912.3930.10.camel@gmail.com \
--to=umgwanakikbuti@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).