From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932782AbcIPLDh (ORCPT ); Fri, 16 Sep 2016 07:03:37 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35511 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbcIPLD3 (ORCPT ); Fri, 16 Sep 2016 07:03:29 -0400 Message-ID: <1474023805.17258.10.camel@gmail.com> Subject: Re: genirq: Setting trigger mode 0 for irq 11 failed (txx9_irq_set_type+0x0/0xb8) From: Alban Browaeys To: Marc Zyngier , Geert Uytterhoeven , Atsushi Nemoto Cc: Linux MIPS Mailing List , "linux-kernel@vger.kernel.org" , Thomas Gleixner , Jon Hunter Date: Fri, 16 Sep 2016 13:03:25 +0200 In-Reply-To: <57DBA464.9010506@arm.com> References: <1473980577.17787.21.camel@gmail.com> <57DBA464.9010506@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le vendredi 16 septembre 2016 à 08:51 +0100, Marc Zyngier a écrit : > Hi Alban, > > On 16/09/16 00:02, Alban Browaeys wrote: > > I am seeing this on arm odroid u2 devicetree : > > genirq: Setting trigger mode 0 for irq 16 failed > > (gic_set_type+0x0/0x64) > > Passing IRQ_TYPE_NONE to a cascading interrupt is risky at best... > Can you point me to the various DTs and their failing interrupts? mine is: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4412-odroidu3.dts I got a report of this issue to another odroid : https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4412-odroidx2.dts they both get their settings from : https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4412.dtsi relevant in the chain are: - combiner modified: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4x12.dtsi#n460 - gic: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi#n576 - gic and combiner initial settings: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos4.dtsi#n134 > Also, can you please give the following patch a go and let me know > if that fixes the issue (I'm interested in the potential warning > here). 1st batch of warnings is : ------------[ cut here ]------------ WARNING: CPU: 0 PID: 0 at kernel/irq/chip.c:833 __irq_do_set_handler+0x1c0/0x1c4 Modules linked in: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.8.0-rc6-debug+ #30 Hardware name: ODROID-U2/U3 [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0xa8/0xd4) [] (dump_stack) from [] (__warn+0xe8/0x100) [] (__warn) from [] (warn_slowpath_null+0x20/0x28) [] (warn_slowpath_null) from [] (__irq_do_set_handler+0x1c0/0x1c4) [] (__irq_do_set_handler) from [] (irq_set_chained_handler_and_data+0x38/0x54) [] (irq_set_chained_handler_and_data) from [] (combiner_of_init+0x1a0/0x1c4) [] (combiner_of_init) from [] (of_irq_init+0x194/0x2e8) [] (of_irq_init) from [] (exynos_init_irq+0x8/0x3c) [] (exynos_init_irq) from [] (init_IRQ+0x2c/0x88) [] (init_IRQ) from [] (start_kernel+0x284/0x388) [] (start_kernel) from [<40008078>] (0x40008078) ---[ end trace f68728a0d3053b52 ]--- 2nd batch is : ------------[ cut here ]------------ WARNING: CPU: 1 PID: 1 at kernel/irq/chip.c:833 __irq_do_set_handler+0x1c0/0x1c4 Modules linked in: CPU: 1 PID: 1 Comm: swapper/0 Tainted: G W 4.8.0-rc6-debug+ #30 Hardware name: ODROID-U2/U3 [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (dump_stack+0xa8/0xd4) [] (dump_stack) from [] (__warn+0xe8/0x100) [] (__warn) from [] (warn_slowpath_null+0x20/0x28) [] (warn_slowpath_null) from [] (__irq_do_set_handler+0x1c0/0x1c4) [] (__irq_do_set_handler) from [] (irq_set_chained_handler_and_data+0x38/0x54) [] (irq_set_chained_handler_and_data) from [] (exynos_eint_wkup_init+0x188/0x2dc) [] (exynos_eint_wkup_init) from [] (samsung_pinctrl_probe+0x874/0xa18) [] (samsung_pinctrl_probe) from [] (platform_drv_probe+0x4c/0xb0) [] (platform_drv_probe) from [] (driver_probe_device+0x24c/0x440) [] (driver_probe_device) from [] (bus_for_each_drv+0x64/0x98) [] (bus_for_each_drv) from [] (__device_attach+0xb4/0x144) [] (__device_attach) from [] (bus_probe_device+0x88/0x90) [] (bus_probe_device) from [] (device_add+0x428/0x5c8) [] (device_add) from [] (of_platform_device_create_pdata+0x84/0xb8) [] (of_platform_device_create_pdata) from [] (of_platform_bus_create+0x164/0x440) [] (of_platform_bus_create) from [] (of_platform_populate+0x80/0x114) [] (of_platform_populate) from [] (of_platform_default_populate_init+0x6c/0x80) [] (of_platform_default_populate_init) from [] (do_one_initcall+0x50/0x198) [] (do_one_initcall) from [] (kernel_init_freeable+0x250/0x2f0) [] (kernel_init_freeable) from [] (kernel_init+0x8/0x114) [] (kernel_init) from [] (ret_from_fork+0x14/0x24) ---[ end trace f68728a0d3053b66 ]--- Best regards, Alban