From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764885AbcIPVDF (ORCPT ); Fri, 16 Sep 2016 17:03:05 -0400 Received: from mail-db5eur01on0096.outbound.protection.outlook.com ([104.47.2.96]:60179 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752425AbcIPVCw (ORCPT ); Fri, 16 Sep 2016 17:02:52 -0400 From: Marcel Ziswiler To: "linux-arm-kernel@lists.infradead.org" , "vladimir_zapolskiy@mentor.com" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "stefan@agner.ch" , "devicetree@vger.kernel.org" , "festevam@gmail.com" , "mark.rutland@arm.com" , "galak@codeaurora.org" , "ijc+devicetree@hellion.org.uk" , "stillcompiling@gmail.com" , "ynezz@true.cz" , "shawnguo@kernel.org" , "l.stach@pengutronix.de" , "kernel@pengutronix.de" , "linux@arm.linux.org.uk" Subject: Re: [PATCH v5 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM Thread-Topic: [PATCH v5 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM Thread-Index: AQHRYDAcRdoqKfkyDEOhveEoPbKJPKBhMi4AgBxJ7IA= Date: Fri, 16 Sep 2016 13:28:42 +0000 Message-ID: <1474032521.3103.17.camel@toradex.com> References: <1454688741-4238-1-git-send-email-marcel.ziswiler@toradex.com> <1454688741-4238-2-git-send-email-marcel.ziswiler@toradex.com> <97a3d506-35a0-2a15-18ef-2719c0596cc1@mentor.com> In-Reply-To: <97a3d506-35a0-2a15-18ef-2719c0596cc1@mentor.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=marcel.ziswiler@toradex.com; x-originating-ip: [84.227.37.153] x-ms-office365-filtering-correlation-id: b99885a3-94c8-4b21-7336-08d3de356107 x-microsoft-exchange-diagnostics: 1;HE1PR05MB1883;6:3aQzwy01YkfrcTyV/b0CK0bvXHsx45y3q8NHz1b6GkxvCRxvADqxufyrvVEnY5wt7yJTk8BclEUkxzv+O+CwvEIG8H0cTMQOyfcfEhgrsLkggmHkRv12wptJRwFQyfKN1aYYOMM7GJKoEvVMs7d68gE80MHL8Hvc0ZY1IZlCpc0TmaEDQaQDrAMb3vbxTNf1BDleMLr+KqpWzrYCMeYyJogzJUte5PYzZowFsP6IGZs9Khnp7VaWYOhphd6U9frJMb5rA7eogvhUdSU4a2AqV35y4PeRTyJ0MIG+gu3usDs=;5:8mXDnPjBGUzcnsdlejxkX+Ho2fF3uLcZLEvZWfXGzrj87Wve30sDitwfmt6o2hwiLW3RWDqSw/qA5S5R4G1vrkxLDTvkIL9lTtoe3Of/yWACyIMQQ6WV5Eia8/KrOY8NRnyr8gybzXyx+j9b+gF1Mg==;24:ZqbUHujPapxuQipBI4zI7MlhdxNUajhQvWo+RIEPr7vrdQyU8eSBtG7Y4qGU4eibawZhix8DKC7nyTpn0p6QXXzK6hmlNkvbG7B2gaPb5ew=;7:/yGNQdqno7nm1ICw63ny4i8NGHnyoywl0SmczlTOtBw3P46tU9SVPFa9x/wKDSIZCDeLR67sfoimFFacBSl09Gzn2t3upn1SPzc8jtErSnef3SeF1Jydi59FFRtepZdc0jKyzez8dtPS7snx9cvPoCsj0Ax2S2PCjjTZrNNw7aTJikLAPjU18wfI0yidomRpSvMs/zC8K3IJkB75HfmcKwJVBBriuJ2R+LxtHkoDd4fIxQU7wA3mFfYGoww++FTp x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1883; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:HE1PR05MB1883;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1883; x-forefront-prvs: 0067A8BA2A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(199003)(377424004)(189002)(377454003)(24454002)(102836003)(4326007)(66066001)(2906002)(3660700001)(189998001)(10400500002)(86362001)(3280700002)(101416001)(81166006)(575784001)(106116001)(105586002)(33646002)(76176999)(81156014)(8676002)(8936002)(50986999)(68736007)(106356001)(54356999)(92566002)(7416002)(2501003)(19580395003)(586003)(5002640100001)(19580405001)(87936001)(7736002)(15975445007)(77096005)(305945005)(7846002)(3846002)(6116002)(122556002)(97736004)(2900100001)(5660300001)(2950100001)(11100500001)(36756003)(103116003)(5001770100001)(32563001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR05MB1883;H:HE1PR05MB1882.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <5B821910886712449054B0EAE428CBF5@eurprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2016 13:28:42.9341 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1883 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u8GL386q015365 Hi Vladimir On Mon, 2016-08-29 at 16:28 +0300, Vladimir Zapolskiy wrote: > Hi Marcel, > > On 02/05/2016 06:12 PM, Marcel Ziswiler wrote: > > > > From: Petr Štetiar > > > > Signed-off-by: Marcel Ziswiler > > Signed-off-by: Petr Štetiar > > Reviewed-by: Stefan Agner > > --- > > > because the change is in mainline now below is kind of out of date > information, but you may find it helpful. > > [snip] > > > > > - fixed HDMI DDC (requires GPIO-based bitbanging I2C to be enabled) > This is not needed. > > [snip] > > > > > + /* DDC_I2C: I2C2_SDA/SCL on MXM3 205/207 */ > > + i2cddc: i2c@0 { > > + compatible = "i2c-gpio"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_i2c_ddc>; > > + gpios = <&gpio3 16 GPIO_ACTIVE_HIGH /* sda */ > > +  &gpio2 30 GPIO_ACTIVE_HIGH /* scl */ > > + >; > > + i2c-gpio,delay-us = <2>; /* ~100 kHz */ > > + status = "disabled"; > > + }; > > + > This is not needed. > > [snip] > > > > > + pinctrl_i2c_ddc: gpioi2cddcgrp { > > + fsl,pins = < > > + /* DDC bitbang */ > > + MX6QDL_PAD_EIM_EB2__GPIO2_IO30 0x1b0b0 > > + MX6QDL_PAD_EIM_D16__GPIO3_IO16 0x1b0b0 > > + >; > > + }; > > + > Practically you don't need this overcomplicated GPIO-based bitbanging > to emulate I2C, because the DW HDMI controller has a reduced I2C > controller on board, you may take a look at its support published > here: > >     http://www.spinics.net/lists/dri-devel/msg116308.html > > To utilize it the pads should be set to HDMI function instead of > I2C or GPIO. Works nicely indeed, thanks for letting us know. > -- > With best wishes, > Vladimir Best wishes to you too! Cheers Marcel