From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964890AbcIPRMo (ORCPT ); Fri, 16 Sep 2016 13:12:44 -0400 Received: from mail-he1eur01on0093.outbound.protection.outlook.com ([104.47.0.93]:53952 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757263AbcIPRMc (ORCPT ); Fri, 16 Sep 2016 13:12:32 -0400 X-Greylist: delayed 10774 seconds by postgrey-1.27 at vger.kernel.org; Fri, 16 Sep 2016 13:12:29 EDT From: Marcel Ziswiler To: "shawnguo@kernel.org" , "maitysanchayan@gmail.com" CC: "stefan@agner.ch" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight Thread-Topic: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight Thread-Index: AQHSDlNKBZat5lIoGEChRjdJUDONMKB8Iq4A Date: Fri, 16 Sep 2016 13:38:54 +0000 Message-ID: <1474033134.3103.27.camel@toradex.com> References: <9d2c17aa2e00e6ff4349a53de8247860d2382607.1473833908.git.maitysanchayan@gmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=marcel.ziswiler@toradex.com; x-originating-ip: [84.227.37.153] x-ms-office365-filtering-correlation-id: 7e19ed05-16c4-45b1-cf39-08d3de36cd87 x-microsoft-exchange-diagnostics: 1;HE1PR05MB1881;6:uYZscxsIiCTvdDah+F1fY3gfwsnhD9JjJgz/qBKuU2jIQJjoPoOsM6ye4eUKXvr/uHTpm5/A/Vct+EsYr1PkcnA8ndNegG1MyZUEguR8FNhwle7Hpb3MME0MyJ8jCTisbb0+QiVqBmBU39pSFbkazUDfA9xXE7PL1rxOMK0WVUHRnTjvidW6uxFnKno4n4tDwx/Hz2iGZhMB/KCKKBDNz/3OA4d9X6o0N8+iJ5r7GqKrD/u62vjqz+sk/N/IBZdGYMjtWmefE435T1/iRM1RLLkl58uiH+1DjTsMVNihZlU=;5:Nm53MrKLtozXB+M8FTmiby0WkODw+EuDstzwRz0myWpG6OvuhJ8+oCzRlZlP3OWb317/PCgrsZuGTcAnfFyLKSkurPIxCa+ey0S2Yx4ljbwMrII7SQwSC8vrinYhEJzIXqalmMTVShfNi/ptRiCU7Q==;24:6JJZvrI1TcB+zA9OUSLhAUg5iA38b5JKicmUxQ+wyPNv3RUYrfgSdhBHtFlC36cQlpq+JFQR9rHAGcMEy6LDKv++sH4DgBe7mpjGxYT0Arg=;7:GWponGFsiOP+LBWCQ4GvMwmGrvxywy1DAEtbg52kzpCL99QtBjmj5lPYmrb+dZBA/7G+eH9Oz+9P1rkevq1AYRUFocTdi0HvSBN4nsW0QaGS8dn9ilAtmYOpgX6nVc4Ci90qJ0upNd2zKsxjfBBT8avfjBmEjU4yyOOV+VpY/A1YhUzfbGUx9A36J4vkh9mT3eKJAa9eNP1PeuRvlap0fD/8993auoqsqtdSjmDPhjGFrOm/5C5kGdyyK4lNu5wr x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1881; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:HE1PR05MB1881;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1881; x-forefront-prvs: 0067A8BA2A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(377424004)(199003)(189002)(24454002)(5002640100001)(189998001)(3280700002)(19580405001)(575784001)(2906002)(92566002)(4326007)(305945005)(8936002)(122556002)(36756003)(87936001)(7846002)(2501003)(7736002)(86362001)(19580395003)(5660300001)(2950100001)(2900100001)(8676002)(101416001)(106116001)(81166006)(6116002)(54356999)(106356001)(76176999)(10400500002)(77096005)(105586002)(81156014)(103116003)(3846002)(97736004)(5001770100001)(68736007)(66066001)(586003)(33646002)(102836003)(3660700001)(50986999)(32563001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR05MB1881;H:HE1PR05MB1882.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2016 13:38:54.6100 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1881 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u8GHCm5d014056 On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote: > Use enable-gpios property of PWM backlight driver for backlight > control. While at it also fix the use of brightness levels required > by EDT displays which require inverted PWM's. That part I am missing below. Did you forget to include it? > Signed-off-by: Sanchayan Maity > --- >  arch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++ >  1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi > b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > index 8c67dd8..9100bde 100644 > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi > @@ -49,7 +49,10 @@ >   >   backlight: backlight { >   compatible = "pwm-backlight"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gpio_bl_on>; >   pwms = <&pwm4 0 5000000>; > + enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>; >   status = "disabled"; >   }; >   > @@ -614,6 +617,12 @@ >   >; >   }; >   > + pinctrl_gpio_bl_on: gpioblon { > + fsl,pins = < > + MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0 > + >; > + }; > + >   pinctrl_gpio_keys: gpio1io04grp { >   fsl,pins = < >   /* Power button */