From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934609AbcIPXdU (ORCPT ); Fri, 16 Sep 2016 19:33:20 -0400 Received: from mga04.intel.com ([192.55.52.120]:59762 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933969AbcIPXdP (ORCPT ); Fri, 16 Sep 2016 19:33:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,347,1470726000"; d="scan'208";a="9875674" Message-ID: <1474068791.10494.2.camel@linux.intel.com> Subject: Re: [PATCH v3 1/3] nvme/scsi: Remove power management support From: J Freyensee To: Christoph Hellwig , Andy Lutomirski Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Keith Busch Date: Fri, 16 Sep 2016 16:33:11 -0700 In-Reply-To: <20160916083333.GB2415@lst.de> References: <714df91022b06c6799afb315962769f22b8ab9f4.1474002926.git.luto@kernel.org> <20160916083333.GB2415@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.4 (3.20.4-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-09-16 at 10:33 +0200, Christoph Hellwig wrote: > On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote: > > > > As far as I can tell, there is basically nothing correct about this > > code.  It misinterprets npss (off-by-one).  It hardcodes a bunch of > > power states, which is nonsense, because they're all just indices > > into a table that software needs to parse.  It completely ignores > > the distinction between operational and non-operational states. > > And, until 4.8, if all of the above magically succeeded, it would > > dereference a NULL pointer and OOPS. > > > > Since this code appears to be useless, just delete it. > > Yes, please! > > Acked-by: Christoph Hellwig Acked-by: Jay Freyensee