From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764407AbcIPXhy (ORCPT ); Fri, 16 Sep 2016 19:37:54 -0400 Received: from mga02.intel.com ([134.134.136.20]:49660 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754384AbcIPXhq (ORCPT ); Fri, 16 Sep 2016 19:37:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,347,1470726000"; d="scan'208";a="1052160758" Message-ID: <1474069064.10494.4.camel@linux.intel.com> Subject: Re: [PATCH v4 1/3] nvme/scsi: Remove power management support From: J Freyensee To: Andy Lutomirski , Keith Busch , Jens Axboe Cc: linux-nvme@lists.infradead.org, Christoph Hellwig , linux-kernel@vger.kernel.org Date: Fri, 16 Sep 2016 16:37:44 -0700 In-Reply-To: <714df91022b06c6799afb315962769f22b8ab9f4.1474049701.git.luto@kernel.org> References: <714df91022b06c6799afb315962769f22b8ab9f4.1474049701.git.luto@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.4 (3.20.4-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-09-16 at 11:16 -0700, Andy Lutomirski wrote: > As far as I can tell, there is basically nothing correct about this > code.  It misinterprets npss (off-by-one).  It hardcodes a bunch of > power states, which is nonsense, because they're all just indices > into a table that software needs to parse.  It completely ignores > the distinction between operational and non-operational states. > And, until 4.8, if all of the above magically succeeded, it would > dereference a NULL pointer and OOPS. > > Since this code appears to be useless, just delete it. Acked-by: Jay Freyensee > > Signed-off-by: Andy Lutomirski > --- >