* [PATCH -next] drm/i915: Fix non static symbol warning
@ 2016-09-17 1:09 Wei Yongjun
2016-09-19 6:33 ` Jani Nikula
0 siblings, 1 reply; 4+ messages in thread
From: Wei Yongjun @ 2016-09-17 1:09 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, David Airlie, Mika Kahola
Cc: Wei Yongjun, intel-gfx, dri-devel, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/gpu/drm/i915/intel_dp.c:1527:5: warning:
symbol 'intel_dp_compute_bpp' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/i915/intel_dp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 69cee9b..acd0c51 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1524,8 +1524,8 @@ void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
}
}
-int intel_dp_compute_bpp(struct intel_dp *intel_dp,
- struct intel_crtc_state *pipe_config)
+static int intel_dp_compute_bpp(struct intel_dp *intel_dp,
+ struct intel_crtc_state *pipe_config)
{
int bpp, bpc;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] drm/i915: Fix non static symbol warning
2016-09-17 1:09 [PATCH -next] drm/i915: Fix non static symbol warning Wei Yongjun
@ 2016-09-19 6:33 ` Jani Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2016-09-19 6:33 UTC (permalink / raw)
To: Wei Yongjun, Daniel Vetter, David Airlie, Mika Kahola
Cc: Wei Yongjun, intel-gfx, dri-devel, linux-kernel
On Sat, 17 Sep 2016, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/i915/intel_dp.c:1527:5: warning:
> symbol 'intel_dp_compute_bpp' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 69cee9b..acd0c51 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1524,8 +1524,8 @@ void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
> }
> }
>
> -int intel_dp_compute_bpp(struct intel_dp *intel_dp,
> - struct intel_crtc_state *pipe_config)
> +static int intel_dp_compute_bpp(struct intel_dp *intel_dp,
> + struct intel_crtc_state *pipe_config)
Already fixed upstream.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next] drm/i915: Fix non static symbol warning
@ 2016-08-21 15:19 Wei Yongjun
2016-08-22 13:03 ` Jani Nikula
0 siblings, 1 reply; 4+ messages in thread
From: Wei Yongjun @ 2016-08-21 15:19 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, David Airlie
Cc: Wei Yongjun, intel-gfx, dri-devel, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/gpu/drm/i915/intel_hotplug.c:480:6: warning:
symbol 'i915_hpd_poll_init_work' was not declared. Should it be static?
Also move the '{' to new line.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/i915/intel_hotplug.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_hotplug.c b/drivers/gpu/drm/i915/intel_hotplug.c
index 5dc2c20..334d47b 100644
--- a/drivers/gpu/drm/i915/intel_hotplug.c
+++ b/drivers/gpu/drm/i915/intel_hotplug.c
@@ -477,7 +477,8 @@ void intel_hpd_init(struct drm_i915_private *dev_priv)
spin_unlock_irq(&dev_priv->irq_lock);
}
-void i915_hpd_poll_init_work(struct work_struct *work) {
+static void i915_hpd_poll_init_work(struct work_struct *work)
+{
struct drm_i915_private *dev_priv =
container_of(work, struct drm_i915_private,
hotplug.poll_init_work);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] drm/i915: Fix non static symbol warning
2016-08-21 15:19 Wei Yongjun
@ 2016-08-22 13:03 ` Jani Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2016-08-22 13:03 UTC (permalink / raw)
To: Wei Yongjun, Daniel Vetter, David Airlie
Cc: Wei Yongjun, intel-gfx, dri-devel, linux-kernel
On Sun, 21 Aug 2016, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/i915/intel_hotplug.c:480:6: warning:
> symbol 'i915_hpd_poll_init_work' was not declared. Should it be static?
>
> Also move the '{' to new line.
Thanks for the patch, but we've already fixed this in
commit 24808e96792a860f3e83e2eb69c5190261716924
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Wed Aug 17 12:09:06 2016 +0100
drm/i915: Mark i915_hpd_poll_init_work as static
BR,
Jani.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/gpu/drm/i915/intel_hotplug.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hotplug.c b/drivers/gpu/drm/i915/intel_hotplug.c
> index 5dc2c20..334d47b 100644
> --- a/drivers/gpu/drm/i915/intel_hotplug.c
> +++ b/drivers/gpu/drm/i915/intel_hotplug.c
> @@ -477,7 +477,8 @@ void intel_hpd_init(struct drm_i915_private *dev_priv)
> spin_unlock_irq(&dev_priv->irq_lock);
> }
>
> -void i915_hpd_poll_init_work(struct work_struct *work) {
> +static void i915_hpd_poll_init_work(struct work_struct *work)
> +{
> struct drm_i915_private *dev_priv =
> container_of(work, struct drm_i915_private,
> hotplug.poll_init_work);
>
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-19 6:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-17 1:09 [PATCH -next] drm/i915: Fix non static symbol warning Wei Yongjun
2016-09-19 6:33 ` Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2016-08-21 15:19 Wei Yongjun
2016-08-22 13:03 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).