From: Meng Yi <meng.yi@nxp.com>
To: <daniel.lezcano@linaro.org>, <tglx@linutronix.de>,
<alexander.stein@systec-electronic.com>
Cc: <linux-kernel@vger.kernel.org>, Meng Yi <meng.yi@nxp.com>
Subject: [PATCH v2] clocksource/fsl: Fix errata A-007728 for flextimer
Date: Sun, 18 Sep 2016 14:46:01 +0800 [thread overview]
Message-ID: <1474181161-1975-1-git-send-email-meng.yi@nxp.com> (raw)
If the FTM counter reaches the FTM_MOD value between the reading of the
TOF bit and the writing of 0 to the TOF bit, the process of clearing the
TOF bit does not work as expected when FTMx_CONF[NUMTOF] != 0 and the
current TOF count is less than FTMx_CONF[NUMTOF]. If the above condition
is met, the TOF bit remains set. If the TOF interrupt is enabled
(FTMx_SC[TOIE] = 1), the TOF interrupt also remains asserted.
Above is the errata discription
The workaround is clearing TOF bit until it is cleaned(FTM counter doesn't
always reache the FTM_MOD anyway),which may cost some cycles.
Signed-off-by: Meng Yi <meng.yi@nxp.com>
---
Change in V2:
-add timeout into IRQ context(suggested by Alexander)
---
drivers/clocksource/fsl_ftm_timer.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/clocksource/fsl_ftm_timer.c b/drivers/clocksource/fsl_ftm_timer.c
index 738515b..86f9186 100644
--- a/drivers/clocksource/fsl_ftm_timer.c
+++ b/drivers/clocksource/fsl_ftm_timer.c
@@ -83,11 +83,13 @@ static inline void ftm_counter_disable(void __iomem *base)
static inline void ftm_irq_acknowledge(void __iomem *base)
{
- u32 val;
+ unsigned long timeout = jiffies + msecs_to_jiffies(100);
- val = ftm_readl(base + FTM_SC);
- val &= ~FTM_SC_TOF;
- ftm_writel(val, base + FTM_SC);
+ /*read and clean the FTM_SC_TOF bit until its cleared*/
+ while ((FTM_SC_TOF & ftm_readl(base + FTM_SC)) &&
+ time_before(jiffies, timeout))
+ ftm_writel(ftm_readl(base + FTM_SC) & (~FTM_SC_TOF),
+ base + FTM_SC);
}
static inline void ftm_irq_enable(void __iomem *base)
--
2.1.0.27.g96db324
next reply other threads:[~2016-09-18 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 6:46 Meng Yi [this message]
2016-09-21 14:34 ` [PATCH v2] clocksource/fsl: Fix errata A-007728 for flextimer Daniel Lezcano
2016-09-22 3:59 ` Meng Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474181161-1975-1-git-send-email-meng.yi@nxp.com \
--to=meng.yi@nxp.com \
--cc=alexander.stein@systec-electronic.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox