From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756555AbcIRJcD (ORCPT <rfc822;w@1wt.eu>);
        Sun, 18 Sep 2016 05:32:03 -0400
Received: from smtprelay0218.hostedemail.com ([216.40.44.218]:43248 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1754427AbcIRJbz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 18 Sep 2016 05:31:55 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3870:3871:3872:3874:4321:5007:10004:10400:10450:10455:10848:11232:11658:11914:12740:13069:13311:13357:13439:13894:14659:14721:19904:19999:21080:30012:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: crack40_1056636ec4924
X-Filterd-Recvd-Size: 1552
Message-ID: <1474191110.1954.16.camel@perches.com>
Subject: Re: Possible code defects: macros and precedence
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Dan Carpenter <error27@gmail.com>, LKML <linux-kernel@vger.kernel.org>
Date: Sun, 18 Sep 2016 02:31:50 -0700
In-Reply-To: <alpine.DEB.2.10.1609180702060.3361@hadrien>
References: <1472927739.5018.13.camel@perches.com>
         <alpine.DEB.2.10.1609041809260.3178@hadrien>
         <1473001581.5018.37.camel@perches.com>
         <alpine.DEB.2.10.1609172221110.3124@hadrien>
         <1474147658.1954.1.camel@perches.com>
         <alpine.DEB.2.10.1609180702060.3361@hadrien>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.21.91-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2016-09-18 at 07:09 +0200, Julia Lawall wrote:
> On Sat, 17 Sep 2016, Joe Perches wrote:
> > I also submitted a similar checkpatch addition that looks
> > for non-comma operators used macro arguments in function
> > definitions.
> >
> > The checkpatch test has the same weakness as the coccinelle
> > test. It doesn't check uses, just the macro definition.
> I wonder if it is really a weakness?  Does anyone care if a macro
> definition has more parentheses than what is necessary for the current
> usage

An excess of parentheses can hurt readability a little.