From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757642AbcIRSdx (ORCPT ); Sun, 18 Sep 2016 14:33:53 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35002 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754189AbcIRSdq (ORCPT ); Sun, 18 Sep 2016 14:33:46 -0400 From: Sudip Mukherjee To: Mark Brown Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] spi: bcm-qspi: fix build error Date: Sun, 18 Sep 2016 19:33:34 +0100 Message-Id: <1474223614-18406-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While building m68k allmodconfig, the build was failing with the error: drivers/spi/spi-bcm-qspi.c:1300:13: error: 'bcm_qspi_suspend' undeclared here (not in a function) .suspend = bcm_qspi_suspend, drivers/spi/spi-bcm-qspi.c:1301:13: error: 'bcm_qspi_resume' undeclared here (not in a function) .resume = bcm_qspi_resume, bcm_qspi_suspend() and bcm_qspi_resume() are only defined when CONFIG_PM_SLEEP is defined. Use the macro SET_SYSTEM_SLEEP_PM_OPS to use it only when CONFIG_PM_SLEEP is defined. Signed-off-by: Sudip Mukherjee --- m68k build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/160355865 drivers/spi/spi-bcm-qspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c index 8fff43e..f06a3824 100644 --- a/drivers/spi/spi-bcm-qspi.c +++ b/drivers/spi/spi-bcm-qspi.c @@ -1297,8 +1297,8 @@ static int bcm_qspi_resume(struct device *dev) #endif /* CONFIG_PM_SLEEP */ const struct dev_pm_ops bcm_qspi_pm_ops = { - .suspend = bcm_qspi_suspend, - .resume = bcm_qspi_resume, + SET_SYSTEM_SLEEP_PM_OPS(bcm_qspi_suspend, + bcm_qspi_resume) }; /* pm_ops to be called by SoC specific platform driver */ EXPORT_SYMBOL_GPL(bcm_qspi_pm_ops); -- 1.9.1