From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932807AbcITGcL (ORCPT ); Tue, 20 Sep 2016 02:32:11 -0400 Received: from smtprelay0196.hostedemail.com ([216.40.44.196]:38850 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754163AbcITGcI (ORCPT ); Tue, 20 Sep 2016 02:32:08 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:2906:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6742:8784:8957:9010:9707:10004:10400:10471:10848:11026:11232:11473:11658:11914:12109:12114:12438:12663:12679:12740:13069:13095:13161:13229:13255:13311:13357:13439:13894:14659:21080:21433:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: fly10_1227ea358d53f X-Filterd-Recvd-Size: 2796 Message-ID: <1474353123.1954.28.camel@perches.com> Subject: Re: "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk()) From: Joe Perches To: Julia Lawall Cc: Al Viro , Ilya Dryomov , Andy Whitcroft , Linus Torvalds , Jean Delvare , Jonathan Corbet , Ceph Development , Alex Elder , Sage Weil , LKML , kernel-janitors@vger.kernel.org, Andrew Morton , linux-doc@vger.kernel.org Date: Mon, 19 Sep 2016 23:32:03 -0700 In-Reply-To: References: <20160920001159.GM2356@ZenIV.linux.org.uk> <1474339566.1954.25.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-09-20 at 07:53 +0200, Julia Lawall wrote: > On Mon, 19 Sep 2016, Joe Perches wrote: > > On Tue, 2016-09-20 at 01:11 +0100, Al Viro wrote: > > > IMO what we need is to go through all rules in CodingStyle and if for > > > some rule there is no overwhelming majority in the core kernel, well, > > > the list has grown way too large and could use massive trimming. > > > > I'm in complete agreement. > > > > I also think that checkpatch's ERROR/WARNING/CHECK message naming is > > far too severe and injunctive and could use a renaming to something > > more silly, bug related and less commanding like FLEAS/GNATS/NITS. > I think it is better to be clear.  CHECK was never really clear to me, > especially if you see it in isolation, on a file that doesn't also have > ERROR or WARNING.  NITS is a common word in this context, but not FLEAS > and GNATS, as far as I know. > There could also be a severity level: high medium and low I agree clarity is good. The seriousness with which some beginners take these message types though is troublesome, Maybe prefix various different types of style messages. Something like: ERROR -> CODE_STYLE_DEFECT WARNING -> CODE_STYLE_UNPREFERRED CHECK -> CODE_STYLE_NIT I doubt additional external documentation would help much. Some checkpatch bleats really are errors though.