From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753610AbcITMNk (ORCPT ); Tue, 20 Sep 2016 08:13:40 -0400 Received: from gate.crashing.org ([63.228.1.57]:36349 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbcITMNj (ORCPT ); Tue, 20 Sep 2016 08:13:39 -0400 Message-ID: <1474373594.2857.62.camel@kernel.crashing.org> Subject: Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs From: Benjamin Herrenschmidt To: Joel Stanley , davem@davemloft.net Cc: gwshan@linux.vnet.ibm.com, andrew@lunn.ch, andrew@aj.id.au, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 20 Sep 2016 22:13:14 +1000 In-Reply-To: <20160920063007.24291-7-joel@jms.id.au> References: <20160920063007.24291-1-joel@jms.id.au> <20160920063007.24291-7-joel@jms.id.au> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-09-20 at 16:00 +0930, Joel Stanley wrote: > On Aspeed SoC with a direct PHY connection (non-NSCI), we receive > continual PHYSTS interrupts: > >  [   20.280000] ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG >  [   20.280000] ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG >  [   20.280000] ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG >  [   20.300000] ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG > > This is because the driver was enabling low-level sensitive interrupt > generation where the systems are wired for high-level. All CPU cycles > are spent servicing this interrupt. If this is a system wiring issue, should it be represented by a DT property ? Cheers, Ben.