From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754372AbcIUD36 (ORCPT ); Tue, 20 Sep 2016 23:29:58 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:32666 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753442AbcIUD34 (ORCPT ); Tue, 20 Sep 2016 23:29:56 -0400 Message-ID: <1474428588.10249.0.camel@mtksdaap41> Subject: Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of_iomap From: James Liao To: Arvind Yadav CC: , , , , , , , , , Date: Wed, 21 Sep 2016 11:29:48 +0800 In-Reply-To: <1474360242-15126-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1474360242-15126-1-git-send-email-arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-09-20 at 14:00 +0530, Arvind Yadav wrote: > From: Arvind Yadav > > Free memory mapping, if init is not successful. > > Signed-off-by: Arvind Yadav Reviewed-by: James Liao > --- > drivers/clk/mediatek/clk-mt8173.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c > index 10c9860..0ac3aee 100644 > --- a/drivers/clk/mediatek/clk-mt8173.c > +++ b/drivers/clk/mediatek/clk-mt8173.c > @@ -1074,8 +1074,10 @@ static void __init mtk_apmixedsys_init(struct device_node *node) > } > > mt8173_pll_clk_data = clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK); > - if (!clk_data) > + if (!clk_data) { > + iounmap(base); > return; > + } > > mtk_clk_register_plls(node, plls, ARRAY_SIZE(plls), clk_data); >