From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753952AbcIUG7i (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Sep 2016 02:59:38 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:34328 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750862AbcIUG7f (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Sep 2016 02:59:35 -0400
Message-ID: <1474441172.27308.19.camel@gmail.com>
Subject: Re: [RFC PATCH v2 3/5] futex: Throughput-optimized (TO) futexes
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Waiman Long <Waiman.Long@hpe.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        Davidlohr Bueso <dave@stgolabs.net>, Jason Low <jason.low2@hpe.com>,
        Scott J Norton <scott.norton@hpe.com>,
        Douglas Hatch <doug.hatch@hpe.com>
Date: Wed, 21 Sep 2016 08:59:32 +0200
In-Reply-To: <1474378963-15496-4-git-send-email-Waiman.Long@hpe.com>
References: <1474378963-15496-1-git-send-email-Waiman.Long@hpe.com>
         <1474378963-15496-4-git-send-email-Waiman.Long@hpe.com>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.16.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-09-20 at 09:42 -0400, Waiman Long wrote:
> This patch introduces a new futex implementation called
> throughput-optimized (TO) futexes.

nit: 'TO' sounds way too much like timeout... TP?  You even use 'to' as
shorthand for timeout in the next patch.

>  		/*
> -> 	> 	>  * Wake robust non-PI futexes here. The wakeup of
> -> 	> 	>  * PI futexes happens in exit_pi_state():
> +> 	> 	>  * Wake robust non-PI/TO futexes here. The wakeup of
> +> 	> 	>  * PI/TO futexes happens in exit_pi_state():
>  > 	> 	>  */

nit: comment attracted my eye during high speed scroll-by.

	-Mike