From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966730AbcIVR5l (ORCPT ); Thu, 22 Sep 2016 13:57:41 -0400 Received: from smtprelay0037.hostedemail.com ([216.40.44.37]:57112 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1033978AbcIVRty (ORCPT ); Thu, 22 Sep 2016 13:49:54 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:967:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6119:6742:7903:7974:8985:9025:10004:10400:10848:11232:11658:11914:12043:12050:12555:12663:12740:13069:13161:13184:13229:13311:13357:13439:13894:14103:14181:14659:14721:21080:21434:21451:30012:30034:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: nest49_55b12b4520824 X-Filterd-Recvd-Size: 2644 Message-ID: <1474566587.8253.14.camel@perches.com> Subject: Re: "CodingStyle: Clarify and complete chapter 7" in docs-next From: Joe Perches To: Jean Delvare Cc: Julia Lawall , Al Viro , Ilya Dryomov , Andy Whitcroft , Linus Torvalds , Jonathan Corbet , Ceph Development , Alex Elder , Sage Weil , LKML , kernel-janitors@vger.kernel.org, Andrew Morton , linux-doc@vger.kernel.org Date: Thu, 22 Sep 2016 10:49:47 -0700 In-Reply-To: <20160922135758.0399725d@endymion> References: <20160920001159.GM2356@ZenIV.linux.org.uk> <1474339566.1954.25.camel@perches.com> <1474353123.1954.28.camel@perches.com> <20160922112407.47da9393@endymion> <1474540930.8253.9.camel@perches.com> <20160922135758.0399725d@endymion> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.21.91-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-09-22 at 13:57 +0200, Jean Delvare wrote: > Sure. But I'm afraid you keep changing topics and I have no idea where > you are going. We started with "should there be a space before jump > labels", then out of nowhere we were discussing the wording of the > output of checkpatch (how is that related?) and now you pull statistics > out of your hat, like these numbers imply anything. No, not out of a hat. Those are the results of a silly script that runs checkpatch on every .[ch] kernel file (but not tools/) with: --show-types --terse --emacs --strict --no-summary --quiet -f The magnitude of "ERRORS" is high and it's not necessary or useful to modify old or obsolete code just to reduce that magnitude. > checkpatch was called checkPATCH for a reason. That's why I promote the --force option to limit using checkpatch on files outside of staging. https://patchwork.kernel.org/patch/9332205/ Andrew?  Are you going to apply that one day? > ERROR means that the new code isn't allowed to do that. Period. Disagree. The compiler doesn't care. The value of consistency in reducing defects is very hard to quantify.