From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759473AbcIWMW2 (ORCPT ); Fri, 23 Sep 2016 08:22:28 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:44121 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757488AbcIWMW0 (ORCPT ); Fri, 23 Sep 2016 08:22:26 -0400 Message-ID: <1474633342.2664.26.camel@pengutronix.de> Subject: Re: [PATCH] drm/i2c: tda998x: don't register the connector From: Lucas Stach To: Daniel Vetter , Liviu Dudau Cc: Linux Kernel Mailing List , dri-devel , Russell King - ARM Linux Date: Fri, 23 Sep 2016 15:22:22 +0300 In-Reply-To: References: <20160808160402.GA24667@e106950-lin.cambridge.arm.com> <20160809060724.GD6232@phenom.ffwll.local> <20160809224812.GJ1041@n2100.armlinux.org.uk> <20160921085738.GA27277@e106950-lin.cambridge.arm.com> <20160921162803.GS1041@n2100.armlinux.org.uk> <20160922103917.GA5632@e106950-lin.cambridge.arm.com> <20160922105155.GT1041@n2100.armlinux.org.uk> <20160922141404.GA5222@e106950-lin.cambridge.arm.com> <20160923093416.GU8917@e106497-lin.cambridge.arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, den 23.09.2016, 12:58 +0200 schrieb Daniel Vetter: > On Fri, Sep 23, 2016 at 11:34 AM, Liviu Dudau > wrote: > > > > rmmod-ing the hdlcd module generates a WARN() splat as the vsync is > > still > > enabled, but we never got the call to turn off the CRTC. Brian is > > still > > tracking through the fbdev emulation to figure out the cause for > > that. > > fbdev emulation doesn't do that for you. If you need/want to shut > down > all the crtcs on driver unload, you need to do that yourself. There's > atomic helpers to do that for you that for you. Which reminds me that my patch (drm/atomic-helper: add unlocked disable all outputs helper) to add such a helper wasn't applied. Probably my own fault by being non-responsive to Seans question. Regards, Lucas