From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035194AbcIWOpJ (ORCPT ); Fri, 23 Sep 2016 10:45:09 -0400 Received: from mga05.intel.com ([192.55.52.43]:33662 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1035091AbcIWOnx (ORCPT ); Fri, 23 Sep 2016 10:43:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,381,1470726000"; d="scan'208";a="1044690216" From: Adrian Hunter To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Masami Hiramatsu , Mathieu Poirier , linux-kernel@vger.kernel.org Subject: [PATCH 11/16] perf intel-pt: Fix missing error codes processing auxtrace_info Date: Fri, 23 Sep 2016 17:38:43 +0300 Message-Id: <1474641528-18776-12-git-send-email-adrian.hunter@intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1474641528-18776-1-git-send-email-adrian.hunter@intel.com> References: <1474641528-18776-1-git-send-email-adrian.hunter@intel.com> Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix 2 places where the err variable was not being set. Signed-off-by: Adrian Hunter --- tools/perf/util/intel-pt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c index 77fbf02c8e41..96519e801e53 100644 --- a/tools/perf/util/intel-pt.c +++ b/tools/perf/util/intel-pt.c @@ -2138,11 +2138,13 @@ int intel_pt_process_auxtrace_info(union perf_event *event, pt->switch_evsel = intel_pt_find_sched_switch(session->evlist); if (!pt->switch_evsel) { pr_err("%s: missing sched_switch event\n", __func__); + err = -EINVAL; goto err_delete_thread; } } else if (pt->have_sched_switch == 2 && !intel_pt_find_switch(session->evlist)) { pr_err("%s: missing context_switch attribute flag\n", __func__); + err = -EINVAL; goto err_delete_thread; } -- 1.9.1