From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759481AbcIXQrs (ORCPT ); Sat, 24 Sep 2016 12:47:48 -0400 Received: from smtprelay0192.hostedemail.com ([216.40.44.192]:52785 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757348AbcIXQrp (ORCPT ); Sat, 24 Sep 2016 12:47:45 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:69:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:3874:4321:5007:6119:6691:7875:7901:7903:8660:10004:10400:10848:11232:11658:11914:12296:12740:13069:13148:13230:13255:13311:13357:13439:13894:14659:14721:21080:21212:21451:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: word19_607fab2f7513c X-Filterd-Recvd-Size: 2352 Message-ID: <1474735656.23838.6.camel@perches.com> Subject: Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect() From: Joe Perches To: SF Markus Elfring Cc: linux-input@vger.kernel.org, Dmitry Torokhov , LKML , kernel-janitors@vger.kernel.org, Julia Lawall In-Reply-To: <8164eb48-e3fa-fa9d-6351-f14b595a6dc3@users.sourceforge.net> References: <1474733610.23838.2.camel@perches.com> <8164eb48-e3fa-fa9d-6351-f14b595a6dc3@users.sourceforge.net> Content-Type: text/plain; charset="ISO-8859-1" Date: Sat, 24 Sep 2016 09:47:36 -0700 Mime-Version: 1.0 X-Mailer: Evolution 3.21.91-1ubuntu1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-09-24 at 18:32 +0200, SF Markus Elfring wrote: > > > @@ -57,27 +57,29 @@ static int joydump_connect(struct gameport *gameport, struct gameport_driver *dr > > >   unsigned long flags; > > >   unsigned char u; > > > >   > > > - printk(KERN_INFO "joydump: ,------------------ START ----------------.\n"); > > > - printk(KERN_INFO "joydump: | Dumping: %30s |\n", gameport->phys); > > > - printk(KERN_INFO "joydump: | Speed: %28d kHz |\n", gameport->speed); > > > + pr_info(",------------------ START ----------------.\n" > > > + "| Dumping: %30s |\n" > > > + "| Speed: %28d kHz |\n", > > > + gameport->phys, > > > + gameport->speed); > > > > Not the same output. > > > Should the desired output be the same when the relevant data are passed by a single function call > (instead of three as before)? Adding a singleton for a pr_fmt #define constant string and updating the printk subsystem to prepend that constant string to each use of a pr_ at runtime would be an improvement as it could reduce constant data used by the format strings. That would be a _real_ improvement. Please try to implement something like that before submitting more of these incorrect patches.